Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctests for error messages in groebner_fan.py #5619

Closed
sagetrac-mvngu mannequin opened this issue Mar 27, 2009 · 3 comments
Closed

doctests for error messages in groebner_fan.py #5619

sagetrac-mvngu mannequin opened this issue Mar 27, 2009 · 3 comments

Comments

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Mar 27, 2009

This is a follow-up to ticket #5465. Here, we add some doctests to check the error messages being raised.

CC: @sagetrac-mhampton

Component: geometry

Keywords: groebner_fan.py

Issue created by migration from https://trac.sagemath.org/ticket/5619

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.0.1 milestone Mar 27, 2009
@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Mar 27, 2009

comment:1

The patch trac_5619-doctests.patch adds two doctests to groebner_fan.py. The doctests check the error messages that can be raised by the functions render() and render3d(). Currently, these error messages are of the NotImplementedError type. This patch depends on ticket #5465.

@sagetrac-mhampton
Copy link
Mannequin

sagetrac-mhampton mannequin commented May 20, 2009

comment:2

Attachment: trac_5619-doctests.patch.gz

These make sense, and appear to work. Positive review.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 21, 2009

comment:3

Merged in Sage 4.0.rc0.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 21, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-4.0.1, sage-4.0 May 21, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants