New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overconvergent modular forms for genus 0 primes #5642
Comments
Attachment: overconvergent-1.patch.gz patch against 3.4.1.alpha0 |
comment:2
REFEREE REPORT:
Anyway, as you can see, I hope you could take each of the main new objects that this code introduces, try each method, and fix the issues. You can probably clean this all up pretty quickly. Please don't take the above in too negative away. This is frickin' awesome code, and I'm very very happy and excited to finally see a real implementation of overconvergent p-adic modular forms in Sage. This is wonderful! |
comment:3
Most of these are plain stupidity on my part and I will fix them, and add doctests to prove that they are fixed. I will also hide some more attributes. |
Attachment: overconvergent-2.patch.gz apply over previous patch |
comment:4
Here's a new version. Overconvergent spaces + elements now inherit from Module and ModuleElement, not HeckeModule and HeckeModuleElement, which is a pity, but leads to fewer meaningless inherited methods. I've also hidden lots of things away out of sight of the user, and improved the documentation somewhat. |
comment:5
OK, this is now very good. Excellent! Thanks!! |
comment:8
Merged both patches in Sage 3.4.1.rc0. Cheers, Michael |
Merged: 3.4.1.rc0 |
Reviewer: William Stein |
Author: David Loeffler |
I have written some code that computes approximations to the q-expansions of overconvergent p-adic modular forms of tame level 1, when p is one of the primes {2, 3, 5, 7, 13} (so X_0(p) has genus 0). See the notes of my talk at the Heilbronn Institute for background:
http://www.dpmms.cam.ac.uk/~dl267/maths/lecturenotes/overconvergent_lecture.pdf.
Component: modular forms
Author: David Loeffler
Reviewer: William Stein
Merged: 3.4.1.rc0
Issue created by migration from https://trac.sagemath.org/ticket/5642
The text was updated successfully, but these errors were encountered: