Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of crystal code: cartan_type now a method rather than attribute #5729

Closed
anneschilling opened this issue Apr 9, 2009 · 6 comments
Closed

Cleanup of crystal code: cartan_type now a method rather than attribute #5729

anneschilling opened this issue Apr 9, 2009 · 6 comments
Assignees
@anneschilling
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-3.4.1

Comments

@anneschilling
Copy link

Crystals: cartan_type is a method

  • Changed the API to have cartan type as a method rather than attribute
  • Systematically use .parent() instead of ._parent
  • Minor doc improvements

CC: @sagetrac-sage-combinat

Component: combinatorics

Issue created by migration from https://trac.sagemath.org/ticket/5729
@anneschilling anneschilling added this to the sage-3.4.1 milestone Apr 9, 2009
@anneschilling anneschilling self-assigned this Apr 9, 2009
@anneschilling
Copy link
Author

Attachment: crystal-cleanup-track.patch.gz

changed according to Nicolas' suggestions

@anneschilling
Copy link
Author

comment:1

Attachment: crystal-5729-track.patch.gz

@nthiery
Copy link
Contributor

nthiery commented Apr 10, 2009

comment:2

Attachment: crystal-5729-track.2.patch.gz

Final version of the patch uploaded:

  • fixes 2/3 remaining calls to parent()
  • Micro doc improvements

@nthiery

This comment has been minimized.

Sign in to view
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 10, 2009

comment:5

Huh? This ticket has not been merged.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin reopened this Apr 10, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 11, 2009

comment:6

Merged crystal-5729-track.2.patch in Sage 3.4.1.rc2.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Apr 11, 2009
@dwbump dwbump mannequin mentioned this issue Apr 23, 2009
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anneschilling anneschilling

Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-3.4.1
Development

No branches or pull requests
2 participants
@nthiery @anneschilling