Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring doctests of modular/modsym/p1list.py up to 100% #5770

Closed
JohnCremona opened this issue Apr 12, 2009 · 5 comments
Closed

Bring doctests of modular/modsym/p1list.py up to 100% #5770

JohnCremona opened this issue Apr 12, 2009 · 5 comments

Comments

@JohnCremona
Copy link
Member

The attached patch completes all docstrings and doctests for the file modular/modsym/p1list.py. I also checked that the html and pdf output in the reference manual look good.

CC: @loefflerd

Component: modular forms

Keywords: modular form documentation

Issue created by migration from https://trac.sagemath.org/ticket/5770

@JohnCremona
Copy link
Member Author

Attachment: p1list-doc.patch.gz

Based on 3.4.1.rc2

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Apr 13, 2009

comment:2

Patch applies fine to 3.4.1.rc2, all doctests pass, and reference manual builds happily. There is just one tiny typo: in the docstring for "apply_S", it has "[-0,1;1,0]" instead of "[0,-1;1,0]". I have uploaded a patch that corrects this.

@loefflerd loefflerd mannequin added the s: positive review label Apr 13, 2009
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Apr 13, 2009

apply over previous patch

@JohnCremona
Copy link
Member Author

comment:3

Attachment: trac_5770-reviewer_fix.patch.gz

Thanks, David. Getting the documentation to build & look ok takes a long time! As you can imagine there was a lot of cutting and pasting. Much more of the same to com with manin_symbols.py, where there are about 5 classes each of which has a very similar set of methods (but not quite identical).

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 13, 2009

comment:4

Merged both patches in Sage 3.4.1.rc3.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Apr 13, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.4.2, sage-3.4.1 Apr 13, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants