Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

random simplicial complexes #5889

Closed
jhpalmieri opened this issue Apr 24, 2009 · 10 comments
Closed

random simplicial complexes #5889

jhpalmieri opened this issue Apr 24, 2009 · 10 comments
Assignees
@jhpalmieri
Labels
c: algebraic topology p: minor / 4 t: enhancement
Milestone
sage-4.0

Comments

@jhpalmieri
Copy link
Member

Add random simplicial complexes to the class of examples of simplicial complexes, so you can do

sage: simplicial_complexes.RandomComplex(6, 2)

to get a random simplicial complex with 6 vertices, all possible edges, and the possible 2-dimensional simplices (triangles) randomly included (or not).

Component: algebraic topology

Author: John Palmieri

Reviewer: Alex Ghitza

Merged: 4.0.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/5889
@jhpalmieri jhpalmieri added this to the sage-4.0 milestone Apr 24, 2009
@jhpalmieri jhpalmieri self-assigned this Apr 24, 2009
@aghitza
Copy link

aghitza commented Apr 30, 2009

comment:1

This looks good.

There is one little issue: as far as I know, you do not need to label the doctest with #random. Sage doctests work in such a way that the same random seed is set before testing, so you will get the same results. So the #random should be removed from line 712.

Apart from that, positive review.

Michael, should we have a new trac component labeled "algebraic topology"? It's a bit weird to have this under "misc", and it will probably come in handy at the next Sage Days in Seattle.

@aghitza aghitza changed the title random simplicial complexes [needs a tiny bit of work] random simplicial complexes Apr 30, 2009
@jhpalmieri
Copy link
Member Author

comment:2

Okay, this patch is identical to the first one, but without "#random". It passes all tests for me on sage.math, although I would like someone else to double-check that.

@jhpalmieri jhpalmieri changed the title [needs a tiny bit of work] random simplicial complexes random simplicial complexes Apr 30, 2009
@jhpalmieri
Copy link
Member Author

Attachment: random-complex.patch.gz

@aghitza
Copy link

aghitza commented Apr 30, 2009

comment:3

It also passes doctests for me.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 30, 2009

comment:4

Alex,

"Algebraic Topology" - here we come. I have made John default owner for now :)

If you want any other component please let me know and I will add them.

Cheers,

Michael

@jhpalmieri
Copy link
Member Author

comment:5

Excellent!

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 11, 2009

comment:6

Merged in Sage 4.0.alpha0.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 11, 2009
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jun 7, 2009

Reviewer: Alex Ghitza

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jun 7, 2009

Author: John Palmieri

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jun 7, 2009

Merged: 4.0.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhpalmieri jhpalmieri

Labels
c: algebraic topology p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-4.0
Development

No branches or pull requests
2 participants
@aghitza @jhpalmieri