New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[woth positive review] clean up schemes/elliptic_curves/ell_generic.py #5890
Comments
comment:1
For the record, to understand William's comment have a look at line 572 of However, his function works for me in 3.4.1, so I think it's already been fixed. |
comment:2
Replying to @aghitza:
I mean of course that it works for me in 3.4.1 without the hackish line that fools Sage into thinking that R is a field. |
comment:3
The attached patch does some cleaning up, and it depends on #5765. It moves all the twists-related methods from It also makes Lastly, the standalone function There are more things to do, but they are issues with the generic code for curves rather than the code for elliptic curves, so I think they should be fixed in |
depends on the latest patch at #5765 |
comment:4
Attachment: trac_5890.patch.gz |
comment:5
Review: first of all, this is just moving code around, all perfectly sensible (lots of stuff moved down from ell_generic to ell_field, and Hasse_bound function moved off to plane curves (where I should have put it in the first place). I applied first 12097.patch (from #5919) then trac_5765-rebased.patch (from #5765) and then trac_5890.patch (from here), all successfully. Doctests in schemes/plane_curves and schemes/elliptic_curves pass. I will give this a positive review, despite the following, which will make it harder to do EC factoring (but the fault lies not in the patch here, rather in moving the test for a point lying on a curve which is now more sophisticated to harder to fool.... but that is not for this ticket to sort out. The example
works but you cannot construct a point in the curve (e.g. E(0,0)) since this happens:
|
comment:6
Merged in Sage 3.4.2.rc0. Cheers, Michael |
As noted at #5765,
ell_generic.py
has some functions that do not make sense over a general ring and should rather be moved down toell_field.py
or one of its descendants.Note also William's comment from #5765: I think it would be nice to be able to implement the elliptic curve factorization method (ECM) without having to use this hack:
CC: @williamstein @JohnCremona
Component: number theory
Keywords: elliptic curve field
Issue created by migration from https://trac.sagemath.org/ticket/5890
The text was updated successfully, but these errors were encountered: