Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve doctest coverage for schemes/jacobians/abstract_jacobian.py #5904

Closed
aghitza opened this issue Apr 26, 2009 · 3 comments
Closed

improve doctest coverage for schemes/jacobians/abstract_jacobian.py #5904

aghitza opened this issue Apr 26, 2009 · 3 comments
Assignees
@aghitza
Labels
c: algebraic geometry p: minor / 4 t: bug t: tests
Milestone
sage-3.4.2

Comments

@aghitza
Copy link

aghitza commented Apr 26, 2009

The attached patch improves the doctest coverage of abstract_jacobian.py from 0% to 85% (6 of 7).

Component: algebraic geometry

Keywords: abstract jacobian doctest

Issue created by migration from https://trac.sagemath.org/ticket/5904
@aghitza aghitza added this to the sage-3.4.2 milestone Apr 26, 2009
@aghitza
Copy link
Author

aghitza commented Apr 26, 2009

Attachment: trac_5904.patch.gz

@aghitza aghitza assigned aghitza and unassigned williamstein Apr 26, 2009
@JohnCremona
Copy link
Member

comment:2

Looks good, applies cleanly to 3.4.2.alpha0 and tests pass. I guess there is no point in adding this to the reference manual as it has no actual functionality really. (As admitted in notes.txt).

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Apr 30, 2009

comment:3

Merged in Sage 3.4.2.rc0.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Apr 30, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghitza aghitza

Labels
c: algebraic geometry p: minor / 4 t: bug t: tests
Projects
None yet
Milestone
sage-3.4.2
Development

No branches or pull requests
3 participants
@aghitza @williamstein @JohnCremona