Bring plot/arrow.py to 100% coverage

[kcrisman]

Bring plot/arrow.py to 100% coverage

Component: documentation

Issue created by migration from https://trac.sagemath.org/ticket/6011

[kcrisman]

comment:1

Attachment: trac_6011.patch.gz

Also adds tiny plot3d enhancement (original doctest only tested Graphics.plot3d).

Please see http://groups.google.com/group/sage-devel/browse_thread/thread/1adac4035031b140/c36f1f8a7c8a9b43#c36f1f8a7c8a9b43 for why there is no loads(dumps()) test. Yet.

[sagetrac-mvngu]

Attachment: trac_6011-reviewer.patch.gz

reviewer patch; add consistency to the whole module

[sagetrac-mvngu]

comment:3

REFEREE REPORT

The patch trac_6011.patch applies OK against the "post-final" version sage-3.4.2, all doctests pass with the options -t -long, and the doctest coverage is now 100% as claimed. Note that sage/plot/arrow.py is not included in the reference manual, so you can't search for it in order to view the documentation for sage/plot/arrow.py.

The patch adds some trivial inconsistencies in how "two-dimensional" and "three-dimensional" are abbreviated. These and other inconsistencies are fixed in the reviewer patch trac_6011-reviewer.patch. Apart from the issue of consistency throughout the whole module, positive review for kcrisman's patch. Only my patch needs to be reviewed.

[sagetrac-mabshoff]

comment:5

Merged both patches in Sage 4.0.alpha0.

Cheers,

Michael