Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage 3.4.2: doctest failure in sage/libs/pari/gen.pyx on 64 bit OSX #6025

Closed
sagetrac-mabshoff mannequin opened this issue May 12, 2009 · 4 comments
Closed

Sage 3.4.2: doctest failure in sage/libs/pari/gen.pyx on 64 bit OSX #6025

sagetrac-mabshoff mannequin opened this issue May 12, 2009 · 4 comments

Comments

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented May 12, 2009

sage -t -long "devel/sage/sage/libs/pari/gen.pyx"           
**********************************************************************
File "/Users/mabshoff/sage-3.4.2-64/devel/sage/sage/libs/pari/gen.pyx", line 8945:
    sage: pari.finitefield_init(7,2)
Exception raised:
    Traceback (most recent call last):
      File "/Users/mabshoff/sage-3.4.2-64/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/mabshoff/sage-3.4.2-64/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/mabshoff/sage-3.4.2-64/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_291[4]>", line 1, in <module>
        pari.finitefield_init(Integer(7),Integer(2))###line 8945:
    sage: pari.finitefield_init(7,2)
    RuntimeError
**********************************************************************
File "/Users/mabshoff/sage-3.4.2-64/devel/sage/sage/libs/pari/gen.pyx", line 8950:
    sage: pari.finitefield_init(2,3)
Exception raised:
    Traceback (most recent call last):
      File "/Users/mabshoff/sage-3.4.2-64/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/Users/mabshoff/sage-3.4.2-64/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/Users/mabshoff/sage-3.4.2-64/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_291[5]>", line 1, in <module>
        pari.finitefield_init(Integer(2),Integer(3))###line 8950:
    sage: pari.finitefield_init(2,3)
    RuntimeError
**********************************************************************
1 items had failures:
   2 of   6 in __main__.example_291
***Test Failed*** 2 failures.
For whitespace errors, see the file /Users/mabshoff/sage-3.4.2-64/tmp/.doctest_gen.py
 [19.0 s]

Component: porting

Issue created by migration from https://trac.sagemath.org/ticket/6025

@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-4.0 milestone May 12, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin self-assigned this May 12, 2009
@craigcitro
Copy link
Member

comment:1

Attachment: trac-6025.patch.gz

As William pointed out on the mailing list, this code isn't used anywhere -- so we're just killing the function. The problem is that on 64 bit OSX, a value getting returned loses its top 4 bytes. This is clearly weird, but since this pari function is known to be buggy, we'll just not use it for now and cross our fingers.

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 13, 2009

comment:2

Ok, good to go.

Cheers,

Michael

@sagetrac-mabshoff
Copy link
Mannequin Author

sagetrac-mabshoff mannequin commented May 13, 2009

comment:3

Merged in Sage 4.0.alpha0.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed May 13, 2009
@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants