Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynkin diagram ascii art for reducible Cartan types #6050

Closed
dwbump mannequin opened this issue May 16, 2009 · 10 comments
Closed

Dynkin diagram ascii art for reducible Cartan types #6050

dwbump mannequin opened this issue May 16, 2009 · 10 comments
Assignees
@dwbump
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-4.0.1

Comments

@dwbump
Copy link
Mannequin

dwbump mannequin commented May 16, 2009

After the patch, Dynkin diagram ascii art is available for reducible Cartan types.

sage: DynkinDiagram("F4xA2")

O---O=>=O---O
1   2   3   4
O---O
5   6
F4xA2

sage: CartanType("B2xC2").dynkin_diagram()

O=>=O
1   2
O=<=O
3   4
B2xC2

The patch trac_6050.patch goes on top of trac_5502-revised.patch but that has been merged in sage-4.0rc0.

The second patch trac_6050-1.patch corrects a minor misformatting in Type D extended ascii art.

Component: combinatorics

Author: Daniel Bump

Reviewer: Mike Hansen

Merged: 4.0.1.rc1

Issue created by migration from https://trac.sagemath.org/ticket/6050
@dwbump dwbump mannequin added c: algebra labels May 16, 2009
@dwbump

This comment has been minimized.

Sign in to view
@dwbump dwbump mannequin self-assigned this May 16, 2009
@dwbump
Copy link
Mannequin Author

dwbump mannequin commented May 17, 2009

comment:3

Attachment: trac_6050.patch.gz

Revised: CartanType in type_reducible.py needed a dynkin_diagram method.

@dwbump

This comment has been minimized.

Sign in to view
@dwbump dwbump mannequin changed the title Dynkin diagram ascii art for reducible Cartan types (with patch, needs review) Dynkin diagram ascii art for reducible Cartan types May 17, 2009
@dwbump
Copy link
Mannequin Author

dwbump mannequin commented May 20, 2009

comment:5

Attachment: trac_6050-1.patch.gz

@dwbump

This comment has been minimized.

Sign in to view
@dwbump dwbump mannequin added this to the sage-4.0.1 milestone May 22, 2009
@mwhansen
Copy link
Contributor

mwhansen commented Jun 4, 2009

comment:7

Looks good to me.

Merged in 4.0.1.rc1.

@mwhansen mwhansen closed this as completed Jun 4, 2009
@mwhansen mwhansen reopened this Jun 4, 2009
@mwhansen
Copy link
Contributor

mwhansen commented Jun 6, 2009

Merged: 4.0.1.rc1

@mwhansen
Copy link
Contributor

mwhansen commented Jun 6, 2009

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Jun 6, 2009

Author: Dan Bump

@fchapoton
Copy link
Contributor

Changed author from Dan Bump to Daniel Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwbump dwbump

Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-4.0.1
Development

No branches or pull requests
2 participants
@mwhansen @fchapoton