Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility functions with deprecation warnings for QF code after doctest patch #6078

Closed
tornaria opened this issue May 19, 2009 · 4 comments

Comments

@tornaria
Copy link
Contributor

The patches at #5954, #6037 and #6040 bring doctest coverage for quadratic forms up to 100%. In this patch series some functions were removed or renamed, so we should add compatibility functions.

These are the functions I propose we should handle:

  • count_modp__by_gauss_sum renamed to count_modp_solutions__by_Gauss_sum.
  • count_local_type was renamed to count_congruence_solutions.
  • count_local_good_type was renamed to count_congruence_solutions__good_type.
  • count_local_zero_type was renamed to count_congruence_solutions__zero_type.
  • count_local_bad_type was renamed to count_congruence_solutions__bad_type.
  • count_local_bad_typeI was renamed to count_congruence_solutions__bad_type_I.
  • count_local_bad_typeII was renamed to count_congruence_solutions__bad_type_II.
  • GHY_mass_maximal was renamed to GHY_mass__maximal.

Component: quadratic forms

Issue created by migration from https://trac.sagemath.org/ticket/6078

@tornaria tornaria added this to the sage-4.0 milestone May 19, 2009
@tornaria
Copy link
Contributor Author

comment:1

Note, there are other functions which were removed, but most of them were not implemented, or wrongly implemented, badly or no documented, etc. It really makes no sense to keep them around.

@sagetrac-mabshoff

This comment has been minimized.

@williamstein
Copy link
Contributor

comment:4

This isn't critical for 4.0.

@williamstein williamstein modified the milestones: sage-4.0, sage-4.0.1 May 28, 2009
@williamstein
Copy link
Contributor

comment:5

I don't see the point in doing this, since quadratic forms was only in Sage for a very short amount of time before making this API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants