Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pynac doesn't simplify exp(x)*exp(2*x) to exp(3*x) #6144

Closed
mwhansen opened this issue May 28, 2009 · 10 comments
Closed

Pynac doesn't simplify exp(x)*exp(2*x) to exp(3*x) #6144

mwhansen opened this issue May 28, 2009 · 10 comments

Comments

@mwhansen
Copy link
Contributor

sage: exp(x)*exp(2*x)
e^(2*x)*e^x

CC: @williamstein

Component: symbolics

Author: Burcin Erocal, Mike Hansen

Reviewer: Nick Alexander, Mike Hansen

Merged: 4.0.1.rc2

Issue created by migration from https://trac.sagemath.org/ticket/6144

@mwhansen mwhansen added this to the sage-4.0.1 milestone May 28, 2009
@burcin
Copy link

burcin commented May 28, 2009

comment:1

GiNaC doesn't do this either:

> exp(x)*exp(2*x);
exp(2*x)*exp(x)

I'll try to play with the mul::eval method in pynac to do this. The main problem is doing it without compromising speed.

Cheers,

Burcin

@burcin
Copy link

burcin commented Jun 4, 2009

Attachment: trac_6144-exp_simplify.patch.gz

@burcin
Copy link

burcin commented Jun 4, 2009

comment:2

Attachment: trac_6144-pynac_depends.patch.gz

New pynac package here fixes the exp simplification:

http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.8.spkg

Attached patches fix doctests, and change module_list.py to rebuild the sage/symbolic/* modules if the package is updated.

This package also contains a fix for #6163, so these tickets should be merged together.

@mwhansen
Copy link
Contributor Author

mwhansen commented Jun 5, 2009

Attachment: trac_6144-review.patch.gz

@mwhansen
Copy link
Contributor Author

mwhansen commented Jun 5, 2009

comment:3

Burcin's changes look good to me. There was one doctest failure that I fixed and put in trac_6144-review.patch

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Jun 5, 2009

comment:4

All looks good to me! I'm glad this is fixed, I updated the number field tests and was disappointed with the previous behaviour.

@mwhansen
Copy link
Contributor Author

mwhansen commented Jun 5, 2009

comment:5

Merged in 4.0.1.rc2.

@mwhansen
Copy link
Contributor Author

mwhansen commented Jun 6, 2009

Merged: 4.0.1.rc2

@mwhansen
Copy link
Contributor Author

mwhansen commented Jun 6, 2009

Author: Burcin Erocal, Mike Hansen

@mwhansen
Copy link
Contributor Author

mwhansen commented Jun 6, 2009

Reviewer: Nick Alexander, Mike Hansen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants