Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip 'nodetex' from the reference manual #6166

Closed
jhpalmieri opened this issue May 31, 2009 · 7 comments
Closed

strip 'nodetex' from the reference manual #6166

jhpalmieri opened this issue May 31, 2009 · 7 comments
Assignees
@mwhansen
Labels
c: documentation p: minor / 4 t: enhancement
Milestone
sage-4.0.1

Comments

@jhpalmieri
Copy link
Member

The patch is supposed to remove 'nodetex' (and any other directives in the same line) from the reference manual; these are already stripped from interactive docstrings by #6122.

CC: @rbeezer @mwhansen

Component: documentation

Author: John Palmieri, Mike Hansen

Reviewer: John Palmieri, Mike Hansen

Merged: 4.0.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6166
@jhpalmieri jhpalmieri added this to the sage-4.0.1 milestone May 31, 2009
@jhpalmieri jhpalmieri self-assigned this May 31, 2009
@jhpalmieri
Copy link
Member Author

Attachment: no-nodetex-ref.patch.gz

@mwhansen
Copy link
Contributor

mwhansen commented Jun 1, 2009

comment:1

Attachment: trac_6166-2.patch.gz

The original patch looks good except it doesn't handle the case when there is an empty docstring. I've added a patch on top which fixes this. John, can you review my small patch?

@mwhansen mwhansen assigned mwhansen and unassigned jhpalmieri Jun 1, 2009
@jhpalmieri
Copy link
Member Author

comment:2

Looks good to me. (Although we just shouldn't allow empty docstrings in the first place :)

@mwhansen
Copy link
Contributor

mwhansen commented Jun 1, 2009

comment:3

I think docstringlines is an empty list if there is no docstring as well.

Merged in 4.0.1.alpha0.

@mwhansen mwhansen closed this as completed Jun 1, 2009
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jun 6, 2009

Reviewer: John Palmieri, Mike Hansen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jun 6, 2009

Author: John Palmieri, Mike Hansen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jun 6, 2009

Merged: 4.0.1.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwhansen mwhansen

Labels
c: documentation p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-4.0.1
Development

No branches or pull requests
2 participants
@mwhansen @jhpalmieri