Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build runs sphinx-build even on failure #6295

Closed
burcin opened this issue Jun 15, 2009 · 4 comments
Closed

build runs sphinx-build even on failure #6295

burcin opened this issue Jun 15, 2009 · 4 comments

Comments

@burcin
Copy link

burcin commented Jun 15, 2009

The build process runs sphinx-build even if a package fails to install. This hides the real error message from the spkg build.

This patch to spkg/install fixes the problem:

--- install.old 2009-06-12 08:46:55.000000000 +0200
+++ install     2009-06-15 11:47:02.000000000 +0200
@@ -357,6 +357,11 @@
 
 time make -f standard/deps $1
 
+if [ $? -ne 0 ]; then
+       echo "Error building Sage."
+       exit 1
+fi
+
 #Build the documentation
 rm -rf "$SAGE_ROOT"/devel/sage-main/doc/output/doctrees
 rm -rf "$SAGE_ROOT"/devel/sage-main/doc/en/reference/sage/*

CC: @craigcitro

Component: build

Author: Burcin Erocal

Reviewer: Craig Citro

Merged: 4.0.2.rc3

Issue created by migration from https://trac.sagemath.org/ticket/6295

@burcin burcin added this to the sage-4.1 milestone Jun 15, 2009
@burcin burcin self-assigned this Jun 15, 2009
@craigcitro
Copy link
Member

Merged: 4.0.2.rc3

@craigcitro
Copy link
Member

Reviewer: Craig Citro

@craigcitro
Copy link
Member

Author: Burcin Erocal

@craigcitro
Copy link
Member

comment:1

Yep, this is a great idea. There's no hg repository there, but I've added the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants