Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional doctest failure -- mistake in constructions guide wrt maxima interface #6319

Open
williamstein opened this issue Jun 16, 2009 · 4 comments

Comments

@williamstein
Copy link
Contributor

This was clearly never tested, since eval always returns a string (it can't return nothing).

sage -t -long --optional devel/sage/doc/en/constructions/plotting.rst
**********************************************************************
File "/scratch/wstein/build/sage-4.0.2.alpha3/devel/sage-main/doc/en/constructions/plotting.rst", line 211:
    sage: maxima.eval('plotdf(x+y,[trajectory_at,2,-0.1]); ') #optional
Expected nothing
Got:
    '1'
**********************************************************************
1 items had failures:
   1 of   4 in __main__.example_11

CC: @maxthemouse

Component: packages: optional

Reviewer: Adam Webb

Issue created by migration from https://trac.sagemath.org/ticket/6319

@wdjoyner
Copy link

applies to 4.0.2.rc1

@wdjoyner
Copy link

comment:1

Attachment: trac_6319.patch.gz

Passes sage -tp 1 SAGE_ROOT/devel/sage/doc/en/constructions/. Also the builds sage -docbuild constructions html (resp., pdf) went fine.

@maxthemouse
Copy link
Mannequin

maxthemouse mannequin commented Jul 16, 2009

Reviewer: Adam Webb

@maxthemouse
Copy link
Mannequin

maxthemouse mannequin commented Jul 16, 2009

comment:2

I still get an error with sage -t -long --optional devel/sage/doc/en/constructions/plotting.rst, although it is with a return value of '0' instead of '1'. It passes sage -tp 1 SAGE_ROOT/devel/sage/doc/en/constructions/ for me as well.

The odd thing is that if I try the test from the sage command line I don't get the string returned i.e. the test passes. Or is it fine if 'sage -t' fails but the documentation is correct for what happens when you actually run it?

Adam

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@mkoeppe mkoeppe removed this from the sage-6.4 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants