New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notebook -- fix that the slideshow mode in the notebook utterly completely broken #6342
Comments
This comment has been minimized.
This comment has been minimized.
comment:3
Attachment: trac_6342.patch.gz Under Ubuntu j & firefox, I can repeatably hit an infinite memory consumption:
|
comment:4
notes on the above comment: Step 1 may be omitted, this bug is active in normal mode. Step 5 should read, "double-click". |
Attachment: trac_6342-part2.patch.gz a tiny little bugfix |
comment:5
Attachment: trac_6342-part3.patch.gz |
make it so slides delimited by text cells with 's; lighten up control css |
comment:6
Attachment: trac_6342-part4.patch.gz Problems:
Comments:
|
comment:8
I just read the new entry in the tutorial. According to the specified behavior (which I don't like), the up&down buttons are almost working -- however,
Reasons I don't like the specified behavior:
By contrast, the version before part-2.patch was clean, simple and intuitive. |
comment:9
This is an unintended bug which I'm fixing.
I'm trying to give an actual talk, and in preparing it, I learned that the version before part-2.patch was actually totally broken crap for actual use. In contrast, what I've just written is really awesome for actual use. There is a huge difference between imagining maybe giving a talk and actually writing a talk you're going to give in front of a 130 people. It is absolutely essential to have slides that are given by a marker. is a very reasonable choice for a marker.
It's going to be a lot more work to implement the counter to show the frames, and I decided not to implement that in the interest of iterative development. |
comment:10
Attachment: trac_6342-part5.patch.gz Slideshow mode now works, shift-enter on HTML cells is still broken. |
comment:11
Oops, the "bottom" button now jumps to the last cell instead of the last frame. |
comment:12
It would be nice if there were some way to
Regarding 1, we could even use something like <sage_slide_break> instead |
comment:13
I think also if there is a newline at the end of an html block, it cuts the slide after the next cell. |
comment:14
Adding a cell to the end of a slide is also problematic. |
comment:19
Closing deprecated notebook tickets |
This patch turns slideshow mode into something actually pretty useful. It is maybe uglier than it was 2 years ago. It is maybe "lame"-ish, perhaps. But it is usable! Which is a million times better than the literally buggy situation now.
The actual patch attached here tracks both the cell_list (the compute cells), and adds a new list allcell_list, which contains all the cells (not just the compute cells).
One other thing -- this patch addresses what looks to me like some terrible scary code in the tinymce integration into Sage. Basically there was a massive junk of javascript that got sent back from the server with each evaluation, and got eval'd via a timeout -- not good. Now it is done statically without any code being eval'd.
Component: notebook
Issue created by migration from https://trac.sagemath.org/ticket/6342
The text was updated successfully, but these errors were encountered: