Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertise and improve sage -fixdoctest #6354

Closed
nthiery opened this issue Jun 18, 2009 · 9 comments
Closed

Advertise and improve sage -fixdoctest #6354

nthiery opened this issue Jun 18, 2009 · 9 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Jun 18, 2009

After this patch, sage -fixdoctest handles multiline doctests,
and use the line number info of sage -t to be more robust (handles
multiple doctests with the same expected output in the same file).

By the way, sage -advanced advertises sage -fixdoctest.

CC: @sagetrac-sage-combinat @mwhansen @rlmill

Component: doctest coverage

Keywords: fix doctests

Author: Nicolas M. Thiéry

Reviewer: Mike Hansen

Merged: sage-4.3.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6354

@nthiery nthiery added this to the sage-4.1 milestone Jun 18, 2009
@nthiery nthiery self-assigned this Jun 18, 2009
@mwhansen
Copy link
Contributor

comment:1

Attachment: sage-fixdoctests-6354-nt.patch.gz

Looks good to me.

@mwhansen
Copy link
Contributor

Changed author from nthiery to Nicolas Thiery

@mwhansen
Copy link
Contributor

Reviewer: Mike Hansen

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jun 24, 2009

Merged: sage-4.1.alpha0

@rlmill rlmill mannequin removed the s: positive review label Jun 24, 2009
@rlmill rlmill mannequin closed this as completed Jun 24, 2009
@nthiery
Copy link
Contributor Author

nthiery commented Nov 17, 2009

comment:3

Replying to @rlmill:

Err, I don't see it in sage-4.2.1; was it somehow lost?

@nthiery
Copy link
Contributor Author

nthiery commented Nov 17, 2009

Changed author from Nicolas Thiery to Nicolas M. Thiéry

@nthiery nthiery reopened this Nov 17, 2009
@rlmill
Copy link
Mannequin

rlmill mannequin commented Nov 17, 2009

comment:4

Sorry, it must have gotten lost during merging....

@nthiery
Copy link
Contributor Author

nthiery commented Nov 17, 2009

comment:5

Replying to @rlmill:

Sorry, it must have gotten lost during merging....

No worry :-) I set it back to positive review so that it get merged in 4.3.

@mwhansen
Copy link
Contributor

Changed merged from sage-4.1.alpha0 to sage-4.3.alpha0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants