Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add generic group functions to the documentation #6450

Closed
sagetrac-ylchapuy mannequin opened this issue Jun 30, 2009 · 7 comments
Closed

add generic group functions to the documentation #6450

sagetrac-ylchapuy mannequin opened this issue Jun 30, 2009 · 7 comments
Labels
c: documentation p: minor / 4 t: enhancement
Milestone
sage-4.1.1

Comments

@sagetrac-ylchapuy
Copy link
Mannequin

sagetrac-ylchapuy mannequin commented Jun 30, 2009

Those are the functions in sage/groups/generic.py

Component: documentation

Keywords: generic group documentation

Author: Yann Laigle-Chapuy

Reviewer: John Cremona

Merged: sage-4.1.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6450
@sagetrac-ylchapuy sagetrac-ylchapuy mannequin added this to the sage-4.1.1 milestone Jun 30, 2009
@JohnCremona
Copy link
Member

Attachment: trac_6450_generic_group_doc.patch.gz

Attachment: trac_6450_review.patch.gz

Apply after previous

@JohnCremona
Copy link
Member

Changed keywords from none to generic group documentation

@JohnCremona
Copy link
Member

Reviewer: John Cremona

@JohnCremona
Copy link
Member

comment:1

Thanks for working on this! It's a great thing to have this file appearing in the reference manual.

I checked that the docs built ok after the patch (which applied fine to 4.1.alpha2), then added a second patch which tidies up the documentation a bit -- since I wrote most of it, I thought that was my duty.

ylchapuy, if you approve of my additional patch then you can give this a postive review.

@sagetrac-ylchapuy
Copy link
Mannequin Author

sagetrac-ylchapuy mannequin commented Jul 1, 2009

comment:2

Nice job. It looks fine to me.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

comment:3

Merged both patches.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 18, 2009

Merged: sage-4.1.1.alpha0

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Jul 18, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-4.1.1
Development

No branches or pull requests
1 participant
@JohnCremona