Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbolic functions should understand numpy arrays #6497

Closed
robertwb opened this issue Jul 9, 2009 · 7 comments
Closed

symbolic functions should understand numpy arrays #6497

robertwb opened this issue Jul 9, 2009 · 7 comments

Comments

@robertwb
Copy link
Contributor

robertwb commented Jul 9, 2009

We want

sage: import numpy
sage: sin(numpy.arange(5))
array([ 0.        ,  0.84147098,  0.90929743,  0.14112001, -0.7568025 ])

Component: calculus

Author: Robert Bradshaw

Reviewer: Burcin Erocal

Merged: Sage 4.1.1.rc0

Issue created by migration from https://trac.sagemath.org/ticket/6497

@burcin
Copy link

burcin commented Jul 12, 2009

comment:1

Attachment: 6497-numpy-sin.patch.gz

This depends on #5081.

@burcin
Copy link

burcin commented Jul 12, 2009

Author: Robert Bradshaw

@burcin
Copy link

burcin commented Jul 12, 2009

Reviewer: Burcin Erocal

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 30, 2009

comment:2

With the patches at #5081 and #6506, and 6497-numpy-sin.patch on this ticket, I got one doctest failure:

sage -t -long devel/sage-main/sage/modules/vector_double_dense.pyx
**********************************************************************
File "/scratch/mvngu/release/sage-4.1.1.alpha1/devel/sage-main/sage/modules/vector_double_dense.pyx", line 663:
    sage: v.stats_kurtosis()
Expected:
    -1.23
Got:
    doctest:106: SyntaxWarning: assertion is always true, perhaps remove parentheses?
    -1.23
**********************************************************************
1 items had failures:
   1 of   6 in __main__.example_29
***Test Failed*** 1 failures.
For whitespace errors, see the file /scratch/mvngu/release/sage-4.1.1.alpha1/tmp/.doctest_vector_double_dense.py
	 [2.5 s]

@robertwb
Copy link
Contributor Author

comment:3

I am unable to reproduce the error above on 4.1.1, so I am re-instating the positive review. (Also, the error itself seems totally unrelated to this patch.)

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 10, 2009

comment:4

Replying to @robertwb:

I am unable to reproduce the error above on 4.1.1, so I am re-instating the positive review. (Also, the error itself seems totally unrelated to this patch.)

The above error is not due to the patch. Ticket #6825 contains steps to reproduce the errors.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 10, 2009

Merged: Sage 4.1.1.rc0

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Sep 10, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants