New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sage banner: include warning if a prerelease #6505
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:4
The change of tiny to some sort of float value seems kind of odd, could this be avoided somehow? 119 {'major': 3, 'minor': 2, 'tiny': 1.2, 'prerelease': False}. |
comment:5
Replying to @sagetrac-mhampton:
I agree that's a bit weird, but when we do really 'use' the value of BTW, I'm working on reviewing this. |
comment:6
This patch looks good, but I did try to use I compiled a source tarball (4.1.rc1), applied the patch (with mq), did a qfinish to get the patch into the regular history, and then tried The sdist script spit out some strange errors, but did create a tarball. I'm compiling that tarball now, but local/bin/sage-banner is an empty file! Also, doing an sdist leaves behind a zombie tree: it looks like it's there, but if you try to run Sage, it doesn't work. This is because of #1065 (!) but even if I do a I do notice that when I try to emulate the
Looks like something fishy in the bit of code that makes the version dictionary. I'll look at this more later, if no one beats to me. BTW, this did pass doctests, so either something is really goofy about the environment above, or we a fix and a new doctest. |
comment:7
Okay, I took a 4.1.rc1 source tarball, compiled it, make a little change, then sdisted it...and it appears to work fine. No significant error messages, and I think the resulting sage-banner file works. So there's something going on with this patch. BTW, above I meant to end with "or we need a fix and a new doctest." |
comment:8
Here is a new version of the patch which doesn't give me this error message. |
Attachment: trac_6505_prerelease.patch.gz |
comment:9
Replying to @dandrake:
Right: I think in recent history, |
comment:10
I'll try to look at the new patch soon. I'm now at a conference and may not have a lot of time, but at the end of this week, the conference will transmogrify into "*-combinat" (http://wiki.sagemath.org/combinat/FPSAC09) so I'll definitely be able to devote time to reviewing by then. |
comment:11
Positive review. This took me a while, since I didn't really know how to use -sdist, but it does work as advertised. |
Reviewer: Dan Drake |
Merged: Sage 4.1.1.alpha1 |
From sage-devel:
This patch should do this. To fully test, make a source distribution of Sage using sage-sdist. To partially test, in Sage, do
I believe that when a Sage distribution is created, the string from
banner_text()
is printed into the file SAGE_ROOT/local/bin/sage-banner (see SAGE_ROOT/local/bin/sage-sdist). So I think this patch will do what was requested.CC: @sagetrac-drkirkby
Component: misc
Author: John Palmieri
Reviewer: Dan Drake
Merged: Sage 4.1.1.alpha1
Issue created by migration from https://trac.sagemath.org/ticket/6505
The text was updated successfully, but these errors were encountered: