Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc sidebar toggle #6507

Closed
qed777 mannequin opened this issue Jul 10, 2009 · 9 comments
Closed

doc sidebar toggle #6507

qed777 mannequin opened this issue Jul 10, 2009 · 9 comments
Labels
c: documentation p: minor / 4 t: enhancement
Milestone
sage-4.1.2

Comments

@qed777
Copy link
Mannequin

qed777 mannequin commented Jul 10, 2009

See sage-devel for an early version.

Component: documentation

Author: Mitesh Patel

Reviewer: Tim Dumol

Merged: Sage 4.1.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/6507
@qed777 qed777 mannequin added c: documentation labels Jul 10, 2009
@qed777
Copy link
Mannequin Author

qed777 mannequin commented Jul 10, 2009

comment:1

Attachment: trac_6507_sidebar_toggle.patch.gz

The new toggle highlights itself on mouse-over, runs the length of the content, auto-resizes itself, uses cookies, and should work in the live, static, and offline documentation in most browsers. This includes Firefox, Opera, and the Qt WebKit demo browser on Linux. Chromium, it seems, does not yet let offline pages set cookies, but more polish is on order.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Jul 27, 2009

comment:2

I applied the patch on r12658 (Sage 4.1). There do not appear to be any differences in the UI.

@TimDumol TimDumol mannequin added the s: needs work label Jul 27, 2009
@qed777
Copy link
Mannequin Author

qed777 mannequin commented Jul 27, 2009

comment:3

Can you be more specific, e.g., about the browser and OS? Did you rebuild the HTML documentation?

I should add that I don't have access to a machine running Mac OS. It would be useful to know how it fares in multiple Mac OS browsers in all three scenarios (live, fast static, offline).

But first, we should try to get it working on some machine other than mine.

(In applying the patch, I got this warning:

Hunk #1 succeeded at 9 with fuzz 1 (offset -1 lines).

This is just a consequence of #6512.)

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Sep 2, 2009

comment:4

Apart from the "fuzz" mentioned above, the patch still appears to work for me. I'm changing the summary to WPNR, but please let me know...

@qed777 qed777 mannequin added s: needs review and removed s: needs work labels Sep 2, 2009
@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Sep 22, 2009

Reviewer: Tim Dumol

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Sep 22, 2009

comment:5

Works as advertised after a doc rebuild. Positive review.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 23, 2009

Merged: Sage 4.1.2.alpha3

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.1.2 milestone Sep 23, 2009
@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Sep 23, 2009
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 27, 2009

comment:7

There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 27, 2009

Changed merged from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4

@TimDumol TimDumol mannequin mentioned this issue Oct 16, 2009
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: documentation p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-4.1.2
Development

No branches or pull requests
0 participants