adding doctests to arith.py

[sagetrac-mhampton]

arith.py currently has quite a few doctests missing. I (Marshall Hampton) am planning on bringing this up to 100% coverage soon.

Component: basic arithmetic

Author: Marshall Hampton, David Loeffler

Reviewer: David Loeffler, Minh Van Nguyen

Merged: sage-4.1.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6529

[sagetrac-mhampton]

Brings arith.py coverage to 100%; includes functions from #6509

[sagetrac-mhampton]

comment:1

Attachment: trac_6529_arith_doctests.patch.gz

Attached patch has functions from ticket #6509 in it as well.

I deleted the optional argument "k=1" from Euler_Phi, since it didn't seem to be there for any reason.

[sagetrac-mhampton]

Reviewer: wstein, craigcitro

[loefflerd]

Attachment: trac_6529_reviewer.patch.gz

[loefflerd]

comment:2

Good work: patch applies fine, and all doctests pass. But I noticed that several docstrings are mis-formatted, including the one for the new four_squares function. Then I had an attack of enthusiasm and decided to clean all that up. Hence the second patch above.

I'm happy with mhampton's changes; so if mhampton (or anyone someone else) could take a quick look at the second patch, then we can call this a positive review.

David

[loefflerd]

Author: Marshall Hampton, David Loeffler

[loefflerd]

Changed reviewer from wstein, craigcitro to David Loeffler

[sagetrac-mvngu]

Merged: sage-4.1.1.alpha0

[sagetrac-mvngu]

Changed reviewer from David Loeffler to David Loeffler, Minh Van Nguyen

[sagetrac-mhampton]

comment:4

Thanks David, that was a lot of cleanup work.