New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function to test whether or not some integer is a primitive root modulo n #6567
Comments
comment:2
Review anyone? |
Author: David Roe |
comment:3
There is a problem in the docstring:
|
Reviewer: Julian Rueth |
comment:4
The doctesting error was due to depending on syntax only valid after #12415. Since I don't want to wait on that, I've updated the doctest (and also marked the dependency correctly). |
Dependencies: #12116 |
comment:5
Should that be Everything else looks nice. I feel like I want to check the logic for numbers divisible by 2, 3, or 5 but where start > 5 a little more closely (getting late here) but if someone else does that first that is fine. |
Attachment: 6567.patch.gz |
comment:6
I'm not quite sure what you meant by the "# now self..." but I made some change along those lines. I'm also not sure why patchbot was giving me a failure in applying. Hopefully the new patch won't have the same problem. |
Attachment: 6567_2.patch.gz Fixes single line in self.is_primitive_root() to make compatible with new 12116.patch |
Changed reviewer from Julian Rueth to Julian Rueth, Simon Spicer |
comment:7
Patch applies, but with the (proposed) change to #12116 - swapping the order integers returned by
to
Everything else is good. |
comment:8
Fine with me. |
comment:9
Please clarify which patch(es) must be applied. |
This comment has been minimized.
This comment has been minimized.
Merged: sage-5.8.beta3 |
Currently, the function
primitive_root()
finds a primitive root modulo n. Ticket #6467 proposes to find all primitive roots modulo a fixed n. We should also implement a function to determine whether or not some integer is a primitive root modulo n. A good way is to do this without first having to generate all primitive roots mod n.Apply attachment: 6567_2.patch
Depends on #12116
CC: @kcrisman
Component: number theory
Keywords: primitive roots
Author: David Roe
Reviewer: Julian Rueth, Simon Spicer
Merged: sage-5.8.beta3
Issue created by migration from https://trac.sagemath.org/ticket/6567
The text was updated successfully, but these errors were encountered: