Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docstring from #5651 #6573

Closed
sagetrac-mvngu mannequin opened this issue Jul 20, 2009 · 9 comments
Closed

fix docstring from #5651 #6573

sagetrac-mvngu mannequin opened this issue Jul 20, 2009 · 9 comments

Comments

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jul 20, 2009

That rebased patch at #5651 contains doctrings that doesn't conform with conventions for formatting docstrings. In particular, in sage/plot/bar_chart.py:

131    Extra options will get passed on to show(), as long as they are valid:

In sage/plot/bezier_path.py:

171    Extra options will get passed on to show(), as long as they are valid:

In sage/plot/matrix_plot.py:

58    Extra options will get passed on to show(), as long as they are valid:
62    Extra options will get passed on to show(), as long as they are valid:

In sage/plot/polygon.py:

255    Extra options will get passed on to show(), as long as they are valid:

CC: @sagetrac-wcauchois @loefflerd

Component: documentation

Author: Minh Van Nguyen

Reviewer: David Loeffler

Merged: Sage 4.1.1.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/6573

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.1.1 milestone Jul 20, 2009
@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Jul 21, 2009

based on Sage 4.1.1.alpha0

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Jul 21, 2009

Author: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Jul 21, 2009

comment:1

Attachment: trac_6573-docstring-fix.patch.gz

David: Can I ask you to review this?

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 21, 2009

Attachment: trac_6573-review.patch.gz

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 21, 2009

Reviewer: David Loeffler

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Jul 21, 2009

comment:2

Looks fine to me; but it looks like the Bezier paths module isn't in the reference manual. I've uploaded a tiny patch that fixes this.

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Jul 23, 2009

comment:3

Merged both patches.

@sagetrac-mvngu
Copy link
Mannequin Author

sagetrac-mvngu mannequin commented Jul 23, 2009

Merged: Sage 4.1.1.alpha1

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Jul 23, 2009
@fchapoton

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant