We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This patch raises SetMorphism to 100% doctest, and implements equality and pickling.
It also renames and doctests the following methods in Map, which were unused and not doctested:
It depends on #6343 (TestSuite)
The category patches #5891
CC: @sagetrac-sage-combinat @sagetrac-cwitty @saliola
Component: coercion
Keywords: SetMorphism
Author: Nicolas M. Thiéry
Reviewer: Mike Hansen
Merged: Sage 4.1.2.alpha2
Issue created by migration from https://trac.sagemath.org/ticket/6597
The text was updated successfully, but these errors were encountered:
Attachment: trac_6597_set_morphism_doc_pickling.patch.gz
Sorry, something went wrong.
Looks good to me. All tests pass with it once #6343 is applied to Sage 4.1.1.
Note it takes awhile to build everything.
Replying to @mwhansen:
Thanks Mike for the review!
Yeah, I had to modify the .pxd of Map (or Morphism) to get pickling to work.
I am glad this will be soon in so that we don't have this patch anymore in Sage-Combinat.
nthiery
No branches or pull requests
This patch raises SetMorphism to 100% doctest, and implements equality and pickling.
It also renames and doctests the following methods in Map, which were
unused and not doctested:
It depends on #6343 (TestSuite)
The category patches #5891
CC: @sagetrac-sage-combinat @sagetrac-cwitty @saliola
Component: coercion
Keywords: SetMorphism
Author: Nicolas M. Thiéry
Reviewer: Mike Hansen
Merged: Sage 4.1.2.alpha2
Issue created by migration from https://trac.sagemath.org/ticket/6597
The text was updated successfully, but these errors were encountered: