Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetMorphism: 100% doctest + equality + pickling; depends on #6343 #6597

Closed
nthiery opened this issue Jul 23, 2009 · 7 comments
Closed

SetMorphism: 100% doctest + equality + pickling; depends on #6343 #6597

nthiery opened this issue Jul 23, 2009 · 7 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Jul 23, 2009

This patch raises SetMorphism to 100% doctest, and implements equality and pickling.

It also renames and doctests the following methods in Map, which were
unused and not doctested:

  • test_extra_slots -> _extra_slots_test
  • update_slots_test -> _update_slots_test

It depends on #6343 (TestSuite)

The category patches #5891

CC: @sagetrac-sage-combinat @sagetrac-cwitty @saliola

Component: coercion

Keywords: SetMorphism

Author: Nicolas M. Thiéry

Reviewer: Mike Hansen

Merged: Sage 4.1.2.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/6597

@nthiery

This comment has been minimized.

@nthiery nthiery changed the title SetMorphism: 100% doctest + equality + pickling SetMorphism: 100% doctest + equality + pickling; depends on #6343 Sep 2, 2009
@nthiery nthiery assigned nthiery and unassigned robertwb Sep 2, 2009
@nthiery
Copy link
Contributor Author

nthiery commented Sep 2, 2009

comment:2

Attachment: trac_6597_set_morphism_doc_pickling.patch.gz

@nthiery

This comment has been minimized.

@mwhansen
Copy link
Contributor

mwhansen commented Sep 8, 2009

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Sep 8, 2009

comment:3

Looks good to me. All tests pass with it once #6343 is applied to Sage 4.1.1.

Note it takes awhile to build everything.

@nthiery
Copy link
Contributor Author

nthiery commented Sep 8, 2009

comment:4

Replying to @mwhansen:

Looks good to me. All tests pass with it once #6343 is applied to Sage 4.1.1.

Thanks Mike for the review!

Note it takes awhile to build everything.

Yeah, I had to modify the .pxd of Map (or Morphism) to get pickling to work.

I am glad this will be soon in so that we don't have this patch anymore in Sage-Combinat.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 9, 2009

Merged: Sage 4.1.2.alpha2

@sagetrac-mvngu sagetrac-mvngu mannequin removed the s: positive review label Sep 9, 2009
@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Sep 9, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants