Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo in totallyreal_rel.py #6767

Closed
sagetrac-fwclarke mannequin opened this issue Aug 16, 2009 · 5 comments
Closed

typo in totallyreal_rel.py #6767

sagetrac-fwclarke mannequin opened this issue Aug 16, 2009 · 5 comments
Assignees
@loefflerd
Labels
c: number fields p: trivial / 5 t: bug
Milestone
sage-4.1.2

Comments

@sagetrac-fwclarke
Copy link
Mannequin

sagetrac-fwclarke mannequin commented Aug 16, 2009

A trivial typo is corrected by the patch.

Component: number fields

Author: Francis Clarke

Reviewer: Minh Van Nguyen

Merged: Sage 4.1.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6767
@sagetrac-fwclarke sagetrac-fwclarke mannequin added this to the sage-4.1.2 milestone Aug 16, 2009
@sagetrac-fwclarke
Copy link
Mannequin Author

sagetrac-fwclarke mannequin commented Aug 16, 2009

Attachment: trac_6767.patch.gz

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Aug 16, 2009

comment:1

Hi Francis. After uploading a patch for a ticket, you should change the subject to "[with patch, needs review]". That way, the ticket can be picked up by the relevant trac report as needing review.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Aug 16, 2009

comment:2

Applied OK against Sage 4.1.1. Passed all doctests. The change looks reasonable.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Aug 16, 2009

Reviewer: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Aug 25, 2009

Merged: Sage 4.1.2.alpha0

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Aug 25, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loefflerd loefflerd

Labels
c: number fields p: trivial / 5 t: bug
Projects
None yet
Milestone
sage-4.1.2
Development

No branches or pull requests
0 participants