New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multinomial to accept lists as argument too #6819
Comments
comment:1
Attachment: 12846.patch.gz |
comment:2
Seems ok to me ! I Applied it, used it, and did not understand why it was not possible already ! By the way, I added some docstrings to the function, so if you think it is ok.. ;-) |
Attachment: multinomial_list.patch.gz patch reviewed + some docstrings |
comment:3
Replying to @nathanncohen:
Thanks for the docstrings. |
Attachment: trac_6819-reviewer.patch.gz ncohen's reviewer patch |
Merged: Sage 4.1.2.alpha0 |
Reviewer: Nathann Cohen |
Author: Rishikesh |
comment:4
The patch ncohen -- Your username should be in your patches; it makes it easier to credit you for your contributions. Please also remember to put in a sensible commit message for your patches. While merging and testing these patches:
I ran into a doctest failure:
This has nothing to do with the above patches. Strangely, it crops up when I run the test on sage.math. But the test passes on mod.math and geom.math. Merged patches in this order:
|
I have modified multinomial to accept lists as argument too. It makes programming with it much easier
Component: algebra
Keywords: arithmetic
Author: Rishikesh
Reviewer: Nathann Cohen
Merged: Sage 4.1.2.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/6819
The text was updated successfully, but these errors were encountered: