ordinal_str giving wrong answers for 111, 112, 113

[simon-king-jena]

The following is incorrect, if I am not mistaken (but I am not a native speaker):

sage: n = 113
sage: n.ordinal_str()
'113rd'
sage: n = 112
sage: n.ordinal_str()
'112nd'
sage: n = 111
sage: n.ordinal_str()
'111st'

With my patch, one gets

sage: n = 111
sage: n.ordinal_str()
'111th'
sage: n = 112
sage: n.ordinal_str()
'112th'
sage: n = 113
sage: n.ordinal_str()
'113th'

while one still has

sage: n = 121
sage: n.ordinal_str()
'121st'
sage: n = 122
sage: n.ordinal_str()
'122nd'
sage: n = 123
sage: n.ordinal_str()
'123rd'

Component: basic arithmetic

Keywords: ordinals

Author: Simon King

Reviewer: Adam Webb

Merged: Sage 4.1.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6842

[simon-king-jena]

Fixing ordinal_str for numbers of the form n100+11, n100+12, n*100+13

[maxthemouse]

comment:1

Attachment: ordinal_str.patch.gz

Looks good to me. It passes unit tests and the documentation builds correctly.

Adam

[maxthemouse]

Reviewer: Adam Webb

[sagetrac-mvngu]

Merged: Sage 4.1.2.alpha0

[JohnCremona]

comment:3

I came along to review this only to find that I was too late. Thanks for fixing the bug (which was mine).