Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancel button in notebook user settings not working #6856

Closed
wjp mannequin opened this issue Sep 1, 2009 · 6 comments
Closed

cancel button in notebook user settings not working #6856

wjp mannequin opened this issue Sep 1, 2009 · 6 comments
Assignees
@boothby
Labels
c: user interface p: major / 3 t: bug
Milestone
sage-4.1.2

Comments

@wjp
Copy link
Mannequin

wjp mannequin commented Sep 1, 2009

The cancel button in the 'Settings' page of a notebook user is not working because of a missing 'username' template argument to account_settings.html. (There's a redirect to a broken path when pressing the button now.)

Component: notebook

Author: Willem Jan Palenstijn

Reviewer: Dan Drake

Merged: Sage 4.1.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/6856
@wjp wjp mannequin added this to the sage-4.1.2 milestone Sep 1, 2009
@wjp wjp mannequin added c: user interface labels Sep 1, 2009
@wjp wjp mannequin assigned boothby Sep 1, 2009
@wjp
Copy link
Mannequin Author

wjp mannequin commented Sep 1, 2009

Attachment: trac_6856-fix_account_settings_cancel.patch.gz

@wjp wjp mannequin added the s: needs review label Sep 1, 2009
@wjp
Copy link
Mannequin Author

wjp mannequin commented Sep 1, 2009

comment:2

To reproduce, log in to the notebook, press 'Settings' at the top right, and then press 'Cancel'.

@dandrake
Copy link
Contributor

dandrake commented Sep 1, 2009

comment:3

A one-line patch that fixes the problem! Positive review.

@dandrake
Copy link
Contributor

dandrake commented Sep 1, 2009

Reviewer: Dan Drake

@dandrake
Copy link
Contributor

dandrake commented Sep 1, 2009

Author: Willem Jan Palenstijn

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 3, 2009

Merged: Sage 4.1.2.alpha0

@sagetrac-mvngu sagetrac-mvngu mannequin removed the s: positive review label Sep 3, 2009
@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Sep 3, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boothby boothby

Labels
c: user interface p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.1.2
Development

No branches or pull requests
2 participants
@boothby @dandrake