Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elliptic curve constructor does not check if the base is a field properly #6879

Closed
JohnCremona opened this issue Sep 3, 2009 · 8 comments
Closed

Comments

@JohnCremona
Copy link
Member

Example:

sage: E = EllipticCurve(QQbar,[1,0])
sage: E.base_field()
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)

/home/jec/sage/isog50.py in <module>()

AttributeError: 'EllipticCurve_generic' object has no attribute 'base_field'

This is because the curve constructed is an ell_generic and not an ell_field, despite {{{QQbar.is_field()}} returning True.

Similarly with RR and CC in place of QQbar.

All that is required is a two-line addition around line 213 of elliptic_curves/constructor.py.

Patch up soon.

CC: @sagetrac-JCooley

Component: elliptic curves

Author: John Cremona

Reviewer: Mike Hansen

Merged: Sage 4.1.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/6879

@JohnCremona
Copy link
Member Author

Attachment: trac_6879-ell_field.patch.gz

Applies to 4.1.1

@JohnCremona
Copy link
Member Author

comment:1

Patched applies to 4.1.1. All sage/schemes/elliptic_curves tests ok.

@JohnCremona
Copy link
Member Author

Author: John Cremona

@mwhansen
Copy link
Contributor

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

comment:3

Looks good to me.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 26, 2009

Merged: Sage 4.1.2.alpha3

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Sep 26, 2009
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 27, 2009

comment:5

There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 27, 2009

Changed merged from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants