Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve _vector_times_matrix #6968

Closed
sagetrac-ylchapuy mannequin opened this issue Sep 20, 2009 · 7 comments
Closed

improve _vector_times_matrix #6968

sagetrac-ylchapuy mannequin opened this issue Sep 20, 2009 · 7 comments

Comments

@sagetrac-ylchapuy
Copy link
Mannequin

sagetrac-ylchapuy mannequin commented Sep 20, 2009

Very small patch avoiding multiple copies

Component: linear algebra

Author: Yann Laigle-Chapuy

Reviewer: William Stein

Merged: Sage 4.1.2.alpha4

Issue created by migration from https://trac.sagemath.org/ticket/6968

@sagetrac-ylchapuy sagetrac-ylchapuy mannequin added this to the sage-4.1.2 milestone Sep 20, 2009
@sagetrac-ylchapuy
Copy link
Mannequin Author

sagetrac-ylchapuy mannequin commented Sep 20, 2009

Attachment: trac_6968_vector_times_matrix.patch.gz

@sagetrac-ylchapuy
Copy link
Mannequin Author

sagetrac-ylchapuy mannequin commented Sep 20, 2009

comment:1

for the record:

before:

sage: m=identity_matrix(1000,sparse=True)
sage: v=vector([1]*1000,sparse=True)
sage: time p = v*m
CPU times: user 2.26 s, sys: 0.00 s, total: 2.26 s
Wall time: 2.26 s 

after:

sage: m=identity_matrix(1000,sparse=True)
sage: v=vector([1]*1000,sparse=True) 
sage: time p = v*m 
CPU times: user 0.20 s, sys: 0.00 s, total: 0.20 s
Wall time: 0.21 s

@sagetrac-ylchapuy sagetrac-ylchapuy mannequin changed the title improve _vector_times_matrix improve _vector_times_matrix [with patch, needs review] Sep 20, 2009
@sagetrac-ylchapuy sagetrac-ylchapuy mannequin changed the title improve _vector_times_matrix [with patch, needs review] improve _vector_times_matrix Sep 20, 2009
@williamstein
Copy link
Contributor

comment:4

Nice!!

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 24, 2009

Merged: Sage 4.1.2.alpha3

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 24, 2009

Reviewer: William Stein

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Sep 24, 2009
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 27, 2009

comment:6

There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 27, 2009

Changed merged from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant