New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update pynac to 0.1.9 #6993
Comments
comment:1
Attachment: trac_6993-revert_evalf.patch.gz This package includes corresponding changes for the tickets:
The patch attached to this ticket is just an enhancement. It is the first step to cleaning up the interface for symbolic functions. Pynac now evaluates symbolic functions on non-exact input again. This eliminates the need for a separate |
comment:2
There are a lot of other doctest failures caused by this package than the ones fixed above. It is possible that some are spurious because I missed something in the tickets listed above, but I will post them here for now.
Both of these have a problem with QQbar(e^(pi*I/3)). This is definitely an algebraic number, so hopefully it's covered elsewhere. Specifically,
This is:
|
Reviewer: Karl-Dieter Crisman |
comment:3
I think you should have been more explicit about how to test this - it wasn't clear that all the patches were necessary to avoid doctest issues. I checked and I think they must all have been related to powers of exp. Anyway, relevant tests pass, the "children" were easy to follow, so the only thing (possibly) hindering positive review is the parenthesis issue in #6948. |
comment:4
New package here: http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.9.p0.spkg Includes printing fixes for #6948. |
comment:5
Positive review! Great. My only complaint is that Pynac is not on the Sage revision control system, so it's both difficult to look at (hence, thanks for the link to the changesets) and difficult to fix symbolic issues in Sage that really "should" live in Pynac. To release manager: apply .p0 package first, then the tickets listed above in reverse numerical order, with #6948 ticket applying first the regular patch, then the print patch. I think that should be the correct order, and should lead to no new doctest failures. (In actual fact, I think that only the patch on this ticket needs to be applied before the others, but that's the order that worked for me.) |
comment:6
Merged |
Merged: Sage 4.1.2.alpha3 |
Author: Burcin Erocal |
comment:7
There is no 4.1.2.alpha3. Sage 4.1.2.alpha3 was William Stein's release for working on making the notebook a standalone package. |
Changed merged from Sage 4.1.2.alpha3 to Sage 4.1.2.alpha4 |
New pynac package available at:
http://sage.math.washington.edu/home/burcin/pynac/pynac-0.1.9.spkg
Changes to pynac can also be viewed by going here:
http://pynac.sagemath.org/hg/rev/beb49aa3cebf
and clicking the link for "children" to see the other patches.
CC: @williamstein @mwhansen @ncalexan
Component: packages: standard
Author: Burcin Erocal
Reviewer: Karl-Dieter Crisman
Merged: Sage 4.1.2.alpha4
Issue created by migration from https://trac.sagemath.org/ticket/6993
The text was updated successfully, but these errors were encountered: