Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symmetrica ignores CC #7032

Closed
sagetrac-drkirkby mannequin opened this issue Sep 27, 2009 · 5 comments
Closed

symmetrica ignores CC #7032

sagetrac-drkirkby mannequin opened this issue Sep 27, 2009 · 5 comments

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Sep 27, 2009

Using

CC was set to the Sun C compiler, and CXX to the Sun C++ compiler. It's apparent that singular is ignoring CC and using gcc instead.

symmetrica-2.0.p4/src/zyk.c
symmetrica-2.0.p4/src/zyk.doc
symmetrica-2.0.p4/src/zykelind.c
Finished extraction
****************************************************
Host system
uname -a:
SunOS swan 5.10 Generic_139555-08 sun4u sparc SUNW,Sun-Blade-1000
****************************************************
****************************************************
CC Version
/opt/xxxsunstudio12.1/bin/cc -v
usage: cc [ options] files.  Use 'cc -flags' for details
****************************************************
make[2]: Entering directory `/export/home/drkirkby/sage/gcc32/sage-4.1.2.alpha2/spkg/build/symmetrica-2.0.p4/src'
gcc -c -O1 -fPIC -g -DFAST -DALLTRUE bar.c
gcc -c -O1 -fPIC -g -DFAST -DALLTRUE bi.c

It does build ok with gcc, even though CC is set to the Sun compiler. There is no C++ code, so I can't immediately tell whether CXX is ignored too, but I suspect it is.

CC: @jaapspies

Component: build

Author: David Kirkby

Reviewer: Jaap Spies

Merged: sage-4.3.1.rc0

Issue created by migration from https://trac.sagemath.org/ticket/7032

@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-4.3.1 milestone Sep 27, 2009
@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 7, 2010

comment:1

I've created a fix for this long standing bug. Basically replacing 'gcc' with '$(CC)' in the makefile.

I also changed spkg-install so SAGE64 was respected at the same time (in fact, that was my main motivation for fixing this ticket, as the failure to observe CC is not fatal, but a failure to observe SAGE64 is).

The symmetica package is odd, in that the SPKG.txt makes it clear that fixes are applied to the source directly, not via patches. I find that a bit odd, but followed in the same way. I needed to fix the 'makefile' but left a copy of what I think is the original makefile as /src/makefile.original

The package now add -m64 with SAGE64 set to yes, and fully respects CC.

This must be updated as a package, and not simply a patch applied, due to the fact that changes are made directly in the src directory.

I've put everything at

http://boxen.math.washington.edu/home/kirkby/portability/symmetrica-2.0.p5/

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Jan 7, 2010

Author: David Kirkby

@jaapspies
Copy link
Member

comment:3

Looks good, works on Fedora and Open Solaris.

Positive review.

Jaap

@jaapspies
Copy link
Member

Reviewer: Jaap Spies

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 14, 2010

Merged: sage-4.3.1.rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant