New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maybe remove linking xpm into gd #7162
Comments
comment:1
It seems sensible to make it standard to me. If you want to post a package, I'll review it. |
Author: David Kirkby |
comment:2
Attachment: 7162.patch.gz A revised .spkg can be found at http://boxen.math.washington.edu/home/kirkby/portability/gd-2.0.35.p3/gd-2.0.35.p3.spkg |
comment:3
Replying to @sagetrac-drkirkby:
This change make the build depend on setting export CFLAGS=-m64 Is this a good thing to do? Jaap |
comment:4
Hi, The purpose of the ticket which William opened was to add
to the line where the configure script it invoked. The ticket had nothing to to with SAGE64. I think whilst trying to build on Solaris in 64-bit mode, you should set CFLAGS and CXXFLAGS to include -m64, as that will allow some packages to build without making changes to their spkg-install files. This is one such package. I've written two scripts (#7505) which check what the compiler is (GCC, Sun Studio, HP, IBM etc). That ticket already has positive review. I've written an updated version of sage-env, #7818 which is awaiting review. That will uses those two script, determine the right compiler flag, then automatically export the right compiler flag to CFLAGS. As such, I believe making only the change William suggested is sufficient in this case. Just export CFLAGS and CXXFLAGS to include -m64, and expect that in the next release or two, that will happen automatically for you. Doing this, will reduce somewhat the number of spkg-install files that need editing. Dave |
Reviewer: Jaap Spies |
comment:6
Ok, nobody is hurt here. People who are porting should know this. So I give it a positive review. Jaap |
Merged: sage-4.3.1.alpha0 |
I'm trying to build sage-4.1.2 on disk.math.washington.edu (opensolaris x86) and had to change the spkg-install of gd-2.0.35.p2:
I added
--without-xpm
.Maybe we should make this standard?
CC: @williamstein @sagetrac-drkirkby @jaapspies
Component: porting: Solaris
Author: David Kirkby
Reviewer: Jaap Spies
Merged: sage-4.3.1.alpha0
Issue created by migration from https://trac.sagemath.org/ticket/7162
The text was updated successfully, but these errors were encountered: