Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sage -coverage aware of TestSuite #7209

Closed
nthiery opened this issue Oct 14, 2009 · 9 comments
Closed

Make sage -coverage aware of TestSuite #7209

nthiery opened this issue Oct 14, 2009 · 9 comments

Comments

@nthiery
Copy link
Contributor

nthiery commented Oct 14, 2009

With the attached patch for sage/local/bin, sage -coverage scans for either a loads(dumps(s)) or a TestSuite(s).run() doctest, and suggests using the later.

Also refines the test whether the file defines a class.

CC: @sagetrac-sage-combinat

Component: doctest coverage

Keywords: TestSuite

Author: Nicolas M. Thiéry

Reviewer: Florent Hivert

Merged: sage-4.2.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/7209

@nthiery nthiery added this to the sage-4.2 milestone Oct 14, 2009
@nthiery nthiery self-assigned this Oct 14, 2009
@nthiery

This comment has been minimized.

@nthiery
Copy link
Contributor Author

nthiery commented Oct 14, 2009

Attachment: trac_7209-coverage-TestSuite-nt.patch.gz

@nthiery

This comment has been minimized.

@hivert
Copy link

hivert commented Oct 19, 2009

Reviewer: Florent Hivert

@hivert
Copy link

hivert commented Oct 19, 2009

comment:4

With the new category framework there will be a lot of parent which will be tested by the testsuite machinery. It is very useful that sage-coverage stop complaining about missing s == loads(dumps(s)) because it is done during
TestSuite(s).run(). The patch looks good and works. Positive review.

Cheers,

Florent

@hivert
Copy link

hivert commented Oct 19, 2009

Changed keywords from none to TestSuite

@jhpalmieri
Copy link
Member

comment:5

Notice that #5819 is somewhat related to this. It would be nice to fix that issue eventually...

@hivert
Copy link

hivert commented Oct 19, 2009

comment:6

Replying to @jhpalmieri:

Notice that #5819 is somewhat related to this. It would be nice to fix that issue eventually...

Sure. But right now our primary goal is to finish the category stuff ASAP...
I'm sorry for this but we really have to take the straight line :-)

Cheers,

Florent

@mwhansen
Copy link
Contributor

Merged: sage-4.2.alpha1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants