Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage -upgrade will try to redownload spkg's that are already present #7241

Closed
mwhansen opened this issue Oct 18, 2009 · 5 comments
Closed

sage -upgrade will try to redownload spkg's that are already present #7241

mwhansen opened this issue Oct 18, 2009 · 5 comments
Labels
c: build p: major / 3 t: bug
Milestone
sage-4.2.1

Comments

@mwhansen
Copy link
Contributor

This causes a problem with flaky internet connections since all of the spkgs have to be able to be downloaded all successfully one right after the other. It shouldn't try to redownload files that are already present.

Component: build

Keywords: upgrade

Author: Mike Hansen

Reviewer: Florent Hivert

Merged: sage-4.2.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7241
@mwhansen mwhansen added this to the sage-4.2.1 milestone Oct 18, 2009
@mwhansen
Copy link
Contributor Author

comment:1

Attachment: trac_7241.patch.gz

It would also be nice to have it use a more robust downloader such as cURL or wget if it is present. The current one doesn't resume downloads.

@hivert
Copy link

hivert commented Nov 7, 2009

Attachment: trac_7241-rebase.patch.gz

@hivert
Copy link

hivert commented Nov 7, 2009

Reviewer: Florent Hivert

@hivert
Copy link

hivert commented Nov 7, 2009

comment:2

For some reason the patch needed a little rebase. I just uploaded a rebased patch which is ready to go. => positive review.

Cheers,

Florent

@mwhansen
Copy link
Contributor Author

mwhansen commented Nov 7, 2009

Merged: sage-4.2.1.alpha0

@mwhansen mwhansen closed this as completed Nov 7, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.2.1
Development

No branches or pull requests
2 participants
@mwhansen @hivert