Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement computation of Silverman height bounds #7266

Closed
williamstein opened this issue Oct 23, 2009 · 8 comments
Closed

implement computation of Silverman height bounds #7266

williamstein opened this issue Oct 23, 2009 · 8 comments

Comments

@williamstein
Copy link
Contributor

The Silverman height bound isn't necessarily as tight at the CPS bound, but it works uniformly over all field extensions, which makes it very useful for some applications, e.g., computing mordell-weil groups over number fields. So let's add it to Sage!

CC: robertwb cremona

Component: number theory

Author: William Stein

Reviewer: Robert Bradshaw

Merged: sage-4.2.1.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7266

@williamstein williamstein added this to the sage-4.2.1 milestone Oct 23, 2009
@williamstein williamstein self-assigned this Oct 23, 2009
@williamstein
Copy link
Contributor Author

comment:1

Attachment: trac_7266.patch.gz

@JohnCremona
Copy link
Member

comment:2

Is there any particular reason for using a native Sage implementation instead of using mwrank/eclib?

I know that #360 has still not been done, but I can't quite see the point of this patch for curves over Q.

@robertwb
Copy link
Contributor

comment:3

Looks good to me. It's a simple enough formula that I'd say the redundant implementation is worth it if just for the ease of introspection.

We're looking at using this for provable computations of Heegner points, where the field of definition is not a priori known.

@JohnCremona
Copy link
Member

comment:4

Replying to @robertwb:

Looks good to me. It's a simple enough formula that I'd say the redundant implementation is worth it if just for the ease of introspection.

We're looking at using this for provable computations of Heegner points, where the field of definition is not a priori known.

Fair point(s). One reason for getting better (usually) bounds for rational points via the CPS method is precisely due to this restriction. I have no objection!

@mwhansen
Copy link
Contributor

Merged: sage-4.2.1.alpha0

@mwhansen
Copy link
Contributor

Changed author from wstein to William Stein

@mwhansen
Copy link
Contributor

Reviewer: Robert Bradshaw

@williamstein
Copy link
Contributor Author

comment:6

But I read here that the Sage project "religiously avoiding redundant code.": http://www.metafilter.com/86262/unbump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants