Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Vertex/Edge disjoint st-paths #7292

Closed
nathanncohen mannequin opened this issue Oct 25, 2009 · 14 comments
Closed

Max Vertex/Edge disjoint st-paths #7292

nathanncohen mannequin opened this issue Oct 25, 2009 · 14 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Oct 25, 2009

With the flow function from #7592, functions returning a maximal number of Vertex/Edge disjoint st-path should be defined. The will obviously use the flow functions, but in many applications the user is just interested in these paths, and so there should be an easy way to find them in Sage.

Component: graph theory

Work Issues: needs rebase (#7634)

Author: Nathann Cohen

Reviewer: Robert Miller

Merged: sage-4.3.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/7292

@nathanncohen nathanncohen mannequin added this to the sage-4.3.1 milestone Oct 25, 2009
@nathanncohen nathanncohen mannequin assigned rlmill Oct 25, 2009
@nathanncohen

This comment has been minimized.

@nathanncohen nathanncohen mannequin added the s: needs review label Dec 15, 2009
@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 15, 2009

comment:3

vertex_disjoint_paths loops forever...

@rlmill rlmill mannequin added s: needs work and removed s: needs review labels Dec 15, 2009
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 16, 2009

comment:4

not anymore :-)

@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 16, 2009

Author: Nathann Cohen

@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 16, 2009

comment:5

Attachment: trac_7292.patch.gz

@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 16, 2009

Reviewer: Robert Miller

@mwhansen
Copy link
Contributor

comment:6

I get the following failure:

**********************************************************************
File "/scratch/mhansen/release/4.3/rc1/sage-4.3.rc1/devel/sage-main/sage/graphs/graph.py", line 3581:
    sage: g.vertex_cover(value_only=True)
Expected:
    9
Got nothing
**********************************************************************

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 20, 2009

comment:7

This is because of an odd thing : when this patch is applied over #7600, the body of vertex_cover totally disappears : only the docstring remains, and the function returns nothing. I will send an updated version of the patch "after" #7600 has been applied :-)

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 20, 2009

comment:8

Here it is !!

Please check, when appying it, that nothing disappears "above" and "after" the added sections ! If this version is not easier to apply, I think the best way would be to create a patch based upon the version you are working on and the patch you already applied (this should not be long though, this patch just adds two consecutive functions)

Sorry for the trouble ! :-)

Nathann

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 6, 2010

Work Issues: needs rebase (#7634)

@rlmill rlmill mannequin added s: needs work and removed s: needs review labels Jan 6, 2010
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Jan 10, 2010

comment:10

Rebased !

Nathann

@nathanncohen nathanncohen mannequin removed the s: needs work label Jan 10, 2010
@nathanncohen nathanncohen mannequin added the s: needs review label Jan 10, 2010
@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 13, 2010

Merged: 4.3.1.alpha2

@rlmill
Copy link
Mannequin

rlmill mannequin commented Jan 13, 2010

comment:11

Attachment: trac_7292-2.patch.gz

positive review

@rlmill rlmill mannequin removed the s: needs review label Jan 13, 2010
@rlmill rlmill mannequin closed this as completed Jan 13, 2010
@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 13, 2010

Changed merged from 4.3.1.alpha2 to sage-4.3.1.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant