Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notebook: default values for variables are printed incorrectly in docstrings #7316

Closed
jhpalmieri opened this issue Oct 26, 2009 · 7 comments
Closed

Comments

@jhpalmieri
Copy link
Member

From sage-notebook:

> I notice that in Sage 4.2, the version of sageinspect in the notebook 
> doesn't match the one in sage.misc -- the one in sagenb/misc is 
> missing the fix from Trac #6848.  As a result, 
> {{{ 
> RDF.random_element? 
> }}} 
> produces incorrect output, as noted on the ticket.  Should this be 
> fixed, or was the fix intentionally omitted because it uses "eval"? 

For the fix, see the patch at #6848, especially the new lines 269-270 (and the associated doctest fixes).

CC: @williamstein

Component: notebook

Author: John Palmieri

Reviewer: Mitesh Patel, Tim Dumol

Issue created by migration from https://trac.sagemath.org/ticket/7316

@qed777
Copy link
Mannequin

qed777 mannequin commented Oct 27, 2009

Attachment: trac_7316-sageinspect_defn.patch.gz

Fix Cython docstring "Definition". Rebase of sageinspect part of #6848. Apply to sagenb repository.

@qed777
Copy link
Mannequin

qed777 mannequin commented Oct 27, 2009

Author: John Palmieri

@qed777
Copy link
Mannequin

qed777 mannequin commented Oct 27, 2009

comment:1

All doctests pass, if I copy the patched sagenb.misc.sageinspect.py to $SAGE_ROOT/devel/sage/sage, say, and run sage -t sageinspect.py in that directory.

To the extent that it counts, my review is positive.

@qed777 qed777 mannequin added the s: needs review label Oct 27, 2009
@jhpalmieri
Copy link
Member Author

comment:2

Is this now a duplicate of #7349?

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Oct 29, 2009

comment:3

Doctests count and the the bugs are fixed. Positive review.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Oct 29, 2009

Reviewer: Mitesh Patel, Tim Dumol

@williamstein
Copy link
Contributor

comment:4

merged into sagenb-0.4.2 (sage-4.2.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants