Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy fails to build on cygwin due to not using the correct fortran compiler #7321

Closed
mwhansen opened this issue Oct 27, 2009 · 10 comments
Closed

Comments

@mwhansen
Copy link
Contributor

The solution is to add 'sage_fortran' to the beginning of the list of fortran compilers on the cygwin line in src/numpy/distutils/fcompiler/init.py

CC: @williamstein

Component: porting: Cygwin

Author: Mike Hansen

Reviewer: Peter Jeremy, William Stein

Merged: sage-4.4.1.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/7321

@mwhansen
Copy link
Contributor Author

Author: Mike Hansen

@mwhansen
Copy link
Contributor Author

comment:1

The spkg can be found a http://sage.math.washington.edu/home/mhansen/numpy-1.3.0.p3.spkg

@mwhansen
Copy link
Contributor Author

mwhansen commented Jan 3, 2010

Attachment: trac_7321-1.patch.gz

@mwhansen
Copy link
Contributor Author

mwhansen commented Jan 3, 2010

Attachment: trac_7321-2.patch.gz

@peterjeremy
Copy link

comment:2

trac_7321-1.patch appears to already be part of numpy-1.3.0.p2 and I won't comment on it.

trac_7321-2.patch appears to be correct and I'll give it a positive review.

OTOH, comparing numpy-1.3.0p2.spkg in sage-4.3 with mhansen/numpy-1.3.0.p3.spkg shows a number of other differences which shouldn't be present:

  • Various emacs backup files (*~) exist
  • Various *.pyc files exist
  • patches/cygwin-core-setup.py has been copied to src/numpy/core/setup.py
  • patches/!init!.py has been copied to src/numpy/distutils/fcompiler/!init!.py
  • patches/gnu.py has been copied to src/numpy/distutils/fcompiler/gnu.py
  • patches/cygwin-lapack_lite-setup.py has been copied to src/numpy/linalg/setup.py
  • src/site.cfg exists
  • src/build exists
    Overall, your numpy-1.3.0.p3.spkg needs rerolling to only include the changes in trac_7321-2.patch

@mwhansen
Copy link
Contributor Author

mwhansen commented Apr 6, 2010

Reviewer: Peter Jeremy

@mwhansen
Copy link
Contributor Author

mwhansen commented Apr 6, 2010

comment:3

I've posted a new spkg based on p2 with only trac_7321-2.patch applied. That should address the above concerns.

@williamstein
Copy link
Contributor

Merged: 4.4.1.alpha2

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Apr 29, 2010

Changed reviewer from Peter Jeremy to Peter Jeremy, William Stein

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented May 3, 2010

Changed merged from 4.4.1.alpha2 to sage-4.4.1.alpha2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants