New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a HTML report for SageNB tests #7390
Comments
Attachment: trac_7390-sagenb_test_report_A.patch.gz HTML test report. Part A. Apply to sagenb repo. |
Attachment: trac_7390-sagenb_test_report_B.patch.gz HTML test report. Part B. Apply to sagenb repo after part A. |
comment:1
Note: The patches depend on #7343. Please apply parts A and B, in order. To test the test report generator, try sage: from sagenb.testing.run_tests import run_and_report; run_and_report() This should run the notebook's Selenium test suite, generate and write a self-contained Remarks:
To do, but not necessarily in this ticket:
|
comment:2
Mistake: |
comment:3
Doctesting may be straightforward. Given
Although the test names |
HTML test report. Part B Version 2. Apply to sagenb repo after part A. |
comment:4
Attachment: trac_7390-sagenb_test_report_B_v2.patch.gz Version 2 (of part B):
|
comment:6
Feel free to suggest improvements to the form and function of the report! |
comment:7
There's sample report at |
comment:8
Replying to @qed777:
If you don't mind, I can try restyling the tests. The colors are a bit jarring, in my opinion. |
comment:9
Feel free. |
Attachment: trac_7390-sagenb_test_report_referee.patch.gz Removes unicode characters from the documentation. Restyles color scheme to a lighter layout. |
Reviewer: Tim Dumol |
comment:10
This patch removes unicode characters from the documentation that would otherwise require magic comments (feel free to do so instead). The color scheme has been inverted to a lighter layout, with colors taken from the color palette on Wikipedia. Things look great. The only thing I might want added are timings for each individual test, but that can go in another patch. Positive review. All that's needed now is for someone to review the referee patch. |
Attachment: trac_7390-sagenb_test_report_referee_v2.patch.gz Update TODO list. Version 2 of referee patch. |
comment:11
Looks good to me. I'll change this status to "positive review." |
comment:12
merged into sagenb for sage-4.3 |
It would be useful to have a HTML report summarizing the results of Sage Notebook tests, including the output and traceback, if any, of each test.
We can begin with the notebook's functional test suites (cf. #7343), but we could add doctests, eventually. And with a backend server, we might select, run, and monitor tests remotely.
CC: @williamstein @TimDumol
Component: notebook
Author: Mitesh Patel
Reviewer: Tim Dumol
Issue created by migration from https://trac.sagemath.org/ticket/7390
The text was updated successfully, but these errors were encountered: