New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sylvester matrix for polynomials #7458
Comments
Attachment: sylvester.patch.gz |
comment:1
Attachment: trac-7458-sylvester-rebase-4.6.patch.gz This is a very basic feature that has to be in Sage. I have rebased Carlo patch to 4.6 but have not touched the code. I have some concerns that makes me mark the patch as needs work:
In particular, I am not sure how to deal with the sylvester matrix of 0 and constant or 0 and 0 Maple for instance return the empty matrix. So in maple: Determinant(Sylvester_Matrix) != Resultant In this corner cases. I will try to check what other CAS do to get a wider picture.
|
Changed keywords from none to Sylvester matrix |
Changed author from carlohamalainen to Carlo Hamalainen |
comment:2
It is not ready for review because the sylvester matrix of (0,0) is not implemented. |
comment:3
Attachment: trac-7458-sylvester-improvements.patch.gz Finally, if one of the polynomials is zero, the code raises a ValueError. |
Changed author from Carlo Hamalainen to Carlo Hamalainen, Luis Felipe Tabera Alonso |
comment:4
Apply trac-7458-sylvester-rebase-4.6.patch, trac-7458-sylvester-improvements.patch |
comment:5
Very nice. I am impressed with the thoroughness of the testing of corner cases here. All doctests in sage/rings pass, and the reference manual builds OK. |
Reviewer: David Loeffler |
Merged: sage-4.6.2.alpha3 |
Small patch to add Sylvester matrix calculation for univariate and multivariate polynomials.
I think that my patch is a bit more general (and has doctests) compared to didier deshommes' patch here, which seems to have never been merged:
http://sage.math.washington.edu/home/dfdeshom/custom/patches/sylveste...
Component: commutative algebra
Keywords: Sylvester matrix
Author: Carlo Hamalainen, Luis Felipe Tabera Alonso
Reviewer: David Loeffler
Merged: sage-4.6.2.alpha3
Issue created by migration from https://trac.sagemath.org/ticket/7458
The text was updated successfully, but these errors were encountered: