Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove '-v' option from 'cp' command (GNUism) in database_cremona_ellcurve #7464

Closed
sagetrac-drkirkby mannequin opened this issue Nov 14, 2009 · 6 comments
Closed

Remove '-v' option from 'cp' command (GNUism) in database_cremona_ellcurve #7464

sagetrac-drkirkby mannequin opened this issue Nov 14, 2009 · 6 comments

Comments

@sagetrac-drkirkby
Copy link
Mannequin

sagetrac-drkirkby mannequin commented Nov 14, 2009

The use of a non-POSIX option '-v' to the 'cp' command prevents this package installing on Solaris. The option, which can also be written as --verbose, is only to show what is actually being copied, so removing it should have no impact.
Therefore

cp -rv cremona $SAGE_DATA/

was changed to

cp -r cremona $SAGE_DATA/

in spkg-install.

I also renamed 'SAGE.txt' to SPKG.txt, and added a slightly better description, and upstream contact information, to make it more consistent with other packages.

This is an optional Sage package.

It is unusual in that the .spkg file, was a tar file, and not a compressed tar file as they usually are.

The updated files can be found at:

http://sage.math.washington.edu/home/kirkby/Solaris-fixes/database_cremona_ellcurve/

Upstream: Reported upstream. Developers acknowledge bug.

CC: @williamstein @sagetrac-drkirkby

Component: porting: Solaris

Keywords: optional GNUism

Author: David Kirkby

Issue created by migration from https://trac.sagemath.org/ticket/7464

@sagetrac-drkirkby sagetrac-drkirkby mannequin added this to the sage-4.3 milestone Nov 14, 2009
@sagetrac-drkirkby sagetrac-drkirkby mannequin self-assigned this Nov 14, 2009
@williamstein
Copy link
Contributor

comment:2

It is unusual in that the .spkg file, was a tar file, and
not a compressed tar file as they usually are.

This is the case for all databases of compressed files. One makes a non-compressed spkg by doing

   sage -pkg_nc directory_name

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Nov 17, 2009

comment:3

Thank you for the information. I used 'tar' to create it, rather than Sage with any option. It seems to work for me. Perhaps you can test it and review it.

@JohnCremona
Copy link
Member

comment:4

This looks fine to me. I read the changed files and also successfully installed it onto 4.2.1. I am happy to be the upstream contact (and would expect to be contacted if anyone found an error in the database). I should probably volunteer to be the spkg maintainer, but (embarrassingly) I do not even know the format of the main data file "cremona" in there! So in practice William is the maintainer. I will ask him to give me instructions....

@williamstein
Copy link
Contributor

comment:5

I do not even know the format of the main data file "cremona" in there!
So in practice William is the maintainer. I will ask him to give me instructions....

It's just a Python pickle.

William

@sagetrac-drkirkby
Copy link
Mannequin Author

sagetrac-drkirkby mannequin commented Nov 27, 2009

Upstream: Reported upstream. Developers acknowledge bug.

@mwhansen
Copy link
Contributor

comment:7

Copied into optional packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants