Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageNB - Include zope.testbrowser and its dependencies in the SageNB package #7468

Closed
TimDumol mannequin opened this issue Nov 15, 2009 · 11 comments
Closed

SageNB - Include zope.testbrowser and its dependencies in the SageNB package #7468

TimDumol mannequin opened this issue Nov 15, 2009 · 11 comments

Comments

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Nov 15, 2009

This package will be used for future testing. Adding another package to a package was also done with the Trac package.

CC: @qed777

Component: notebook

Author: Tim Dumol

Reviewer: William Stein

Merged: sagenb-0.4.8

Issue created by migration from https://trac.sagemath.org/ticket/7468

@TimDumol TimDumol mannequin added this to the sage-4.3.1 milestone Nov 15, 2009
@TimDumol TimDumol mannequin assigned boothby Nov 15, 2009
@TimDumol
Copy link
Mannequin Author

TimDumol mannequin commented Nov 15, 2009

Adds zope.testbrowser to the package's dependencies and makes spkg-dist automatically download the dependencies. Depends on #7467

@TimDumol
Copy link
Mannequin Author

TimDumol mannequin commented Nov 15, 2009

comment:1

Attachment: trac_7468-zope.testbrowser.patch.gz

This should do the trick.

@TimDumol TimDumol mannequin added the s: needs review label Nov 15, 2009
@qed777
Copy link
Mannequin

qed777 mannequin commented Nov 26, 2009

comment:2

Is zope.testbrowser (or does it appear to be) sufficiently powerful to implement a [nearly] complete Sage Remote Access API (cf. this comment at #7343)?

Programmatic possibilities: login/out; create, archive, delete, rename, share, up/download, publish worksheets; add/remove data files.

@williamstein
Copy link
Contributor

comment:3

This patch is totally unacceptable as is. The problem is this:

(1) Turn off your internet connection, then

(2) Try doing "sage -python setup.py install", and you get

...
Reading http://pypi.python.org/simple/zope.testbrowser/
Download error: [Errno 8] nodename nor servname provided, or not known -- Some packages may not be found!
Reading http://pypi.python.org/simple/zope.testbrowser/
Download error: [Errno 8] nodename nor servname provided, or not known -- Some packages may not be found!
Couldn't find index page for 'zope.testbrowser' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading http://pypi.python.org/simple/
Download error: [Errno 8] nodename nor servname provided, or not known -- Some packages may not be found!
No local packages or download links found for zope.testbrowser>=3.7.0a1
error: Could not find suitable distribution for Requirement.parse('zope.testbrowser>=3.7.0a1')

Now imagine that you're building Sage from source on an airplane, or while camping, or working at a job which for security reasons doesn't allow outside network connections.

Options:

(1) Get zope.testbrowser included as a standard sage package.

(2) Make the dependency on zope.testbrowser optional.

-- william

@TimDumol
Copy link
Mannequin Author

TimDumol mannequin commented Dec 9, 2009

comment:4

I have edited the spkg-dist file, which I believe is used for creating the sagenb spkg, in this patch to automatically download zope.testbrowser and its dependencies, and include it in the spkg. Thus, installing through sage -i sagenb or spkg-install should not require internet access. Inclusion of package dependencies is also done in the Twisted package (zope.interface) and in the Trac package (Genshi).

Please correct me if I am mistaken, though.

@TimDumol TimDumol mannequin added s: needs review and removed s: needs work labels Dec 9, 2009
@williamstein
Copy link
Contributor

comment:5

Please correct me if I am mistaken, though.

No, that should be fine, and is probably a good idea. Can you post your edited spkg-dist file?

@williamstein
Copy link
Contributor

comment:6

Oops, I stupidly missed that you had already done that 3 weeks ago! Thanks for teaching me setuptools. :-) This indeed looks fine.

@williamstein
Copy link
Contributor

comment:7

Merged into sagenb-0.4.8.

@kcrisman
Copy link
Member

kcrisman commented Jan 4, 2010

Reviewer: William Stein

@kcrisman
Copy link
Member

kcrisman commented Jan 4, 2010

Author: Tim Dumol

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Jan 7, 2010

Merged: sagenb-0.4.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants