Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_finite method in categories (was Primes is missing is_finite) #7510

Closed
hivert opened this issue Nov 21, 2009 · 7 comments
Closed

is_finite method in categories (was Primes is missing is_finite) #7510

hivert opened this issue Nov 21, 2009 · 7 comments
Assignees
@hivert
Labels
c: categories p: major / 3 t: bug
Milestone
sage-4.3

Comments

@hivert
Copy link

hivert commented Nov 21, 2009

I found that Primes has no methods is_finite. This is actually not a problem of Prime but should be dealt in categories. I put a small patch here though i'm not sure we want to do this. Isn't this redundent with categories ?

Cheers,

Florent

Component: categories

Keywords: Primes, is_finite

Author: Florent Hivert

Reviewer: Mike Hansen

Merged: sage-4.3.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/7510
@hivert hivert added this to the sage-4.3 milestone Nov 21, 2009
@hivert hivert assigned williamstein and hivert and unassigned williamstein Nov 21, 2009
@hivert

This comment has been minimized.

Sign in to view
@hivert hivert changed the title Primes is missing is_finite. is_finite method in categories (was Primes is missing is_finite). Nov 21, 2009
@mwhansen
Copy link
Contributor

comment:4

For the second example, don't you want an EnumeratedSet and not a FiniteEnumeratedSet?

@hivert
Copy link
Author

hivert commented Nov 21, 2009

Attachment: trac_7510-is_finite_categories.patch.gz

@hivert
Copy link
Author

hivert commented Nov 21, 2009

comment:5

Replying to @mwhansen:

For the second example, don't you want an EnumeratedSet and not a FiniteEnumeratedSet?

Sure ! The example didn't even pass the test... I forgot to re-export before uploading the patch... Thank for pointing this out and sorry for the trouble...

@mwhansen
Copy link
Contributor

mwhansen commented Dec 1, 2009

comment:6

Looks good.

@mwhansen
Copy link
Contributor

mwhansen commented Dec 1, 2009

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Dec 1, 2009

Merged: sage-4.3.alpha1

@mwhansen mwhansen closed this as completed Dec 1, 2009
@sagetrac-mvngu sagetrac-mvngu mannequin changed the title is_finite method in categories (was Primes is missing is_finite). is_finite method in categories (was Primes is missing is_finite) Dec 26, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hivert hivert

Labels
c: categories p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.3
Development

No branches or pull requests
3 participants
@mwhansen @williamstein @hivert