Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derivative alias for diff #753

Closed
robertwb opened this issue Sep 25, 2007 · 7 comments
Closed

derivative alias for diff #753

robertwb opened this issue Sep 25, 2007 · 7 comments

Comments

@robertwb
Copy link
Contributor

For all polynomials and mpolynomials

Component: calculus

Issue created by migration from https://trac.sagemath.org/ticket/753

@sagetrac-mabshoff sagetrac-mabshoff mannequin added the t: feature label Sep 26, 2007
@mwhansen mwhansen assigned mwhansen and unassigned williamstein Nov 30, 2007
@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-2.9.1 milestone Dec 18, 2007
@sagetrac-mabshoff sagetrac-mabshoff mannequin removed the t: feature label Dec 18, 2007
@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Jan 2, 2008

comment:4

arrggh this is a bit of a mess currently. All the types seem to behave differently at the moment. Some standardisation is really needed here, and things pulled back closer to the base classes. Examples:

sage: x = var("x")
sage: type(x)
<class 'sage.calculus.calculus.SymbolicVariable'>
sage: x.diff()
1
sage: x.derivative()
1
sage: x.differentiate()
1

sage: R.<x> = PolynomialRing(ZZ)
sage: x.derivative()
1
sage: x.diff()
[boom]

sage: R.<x> = PolynomialRing(QQ)
sage: x.diff()
---------------------------------------------------------------------------
<type 'exceptions.TypeError'>             Traceback (most recent call last)

/home/dmharvey/<ipython console> in <module>()

<type 'exceptions.TypeError'>: diff() takes at least 2 arguments (1 given)
sage: x.derivative()
1

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Feb 28, 2008

comment:5

Attached patch revamps all derivative functions in sage, and also covers #756 and #1578.

This has been tested (sort of) on 2.10.2.

I'm now going to try against mabshoff's pseudo-2.10.3.rc0.

I'm not sure whether this should be targeted at 2.10.3 or 2.10.4.

@sagetrac-dmharvey sagetrac-dmharvey mannequin assigned sagetrac-dmharvey and unassigned mwhansen Feb 28, 2008
@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Feb 28, 2008

comment:6

Attachment: derivative.patch.gz

@sagetrac-dmharvey
Copy link
Mannequin

sagetrac-dmharvey mannequin commented Mar 2, 2008

comment:7

Attachment: derivative2.patch.gz

I've added an additional file derivative2.patch which incorporates a missing file (derivative.pyx)

@sagetrac-cwitty
Copy link
Mannequin

sagetrac-cwitty mannequin commented Mar 2, 2008

comment:8

Attachment: derivative-reviewer.patch.gz

Looks good to me! "sage -testall" passes, code and doctests look good. I added a patch that changes some indirect doctests to direct doctests, and fixes a 1-character typo.

Apply all three patches.

@mwhansen
Copy link
Contributor

mwhansen commented Mar 2, 2008

comment:9

All doctests pass for me too.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 2, 2008

comment:10

Merged all three patches in Sage 2.10.3.rc1

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 2, 2008
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants