Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a deprecation message at the top of most sage.server.* files #7534

Closed
qed777 mannequin opened this issue Nov 26, 2009 · 13 comments
Closed

Add a deprecation message at the top of most sage.server.* files #7534

qed777 mannequin opened this issue Nov 26, 2009 · 13 comments

Comments

@qed777
Copy link
Mannequin

qed777 mannequin commented Nov 26, 2009

To avoid confusion, we should add a message to the top of each old Sage notebook .py file stating that one should work on SageNB instead.

This should be a patch to the core Sage library.

CC: @TimDumol @williamstein

Component: notebook

Author: Tim Dumol

Reviewer: Mike Hansen

Merged: sage-4.3.rc1

Issue created by migration from https://trac.sagemath.org/ticket/7534

@qed777 qed777 mannequin added c: user interface labels Nov 26, 2009
@qed777 qed777 mannequin assigned boothby Nov 26, 2009
@qed777
Copy link
Mannequin Author

qed777 mannequin commented Nov 26, 2009

comment:1

How about

This file is part of the OLD Sage notebook and is NOT actively developed,
maintained, or supported.  As of Sage v4.1.2, all notebook development has
moved to the separate Sage Notebook project:

http://nb.sagemath.org/

The new notebook is installed in Sage as a spkg (e.g., sagenb-0.3.spkg).

Please visit the project's home page for more information, including directions on
obtaining the latest source code.  For notebook-related development and support,
please consult the sage-notebook discussion group:

http://groups.google.com/group/sage-notebook

?

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Nov 26, 2009

comment:2

See sage-notebook.

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Nov 30, 2009

Adds the recommended deprecation message (with typo correction)

@TimDumol
Copy link
Mannequin

TimDumol mannequin commented Nov 30, 2009

comment:3

Attachment: trac_7534-deprecation-message.gz

This should do the job.

@TimDumol TimDumol mannequin added the s: needs review label Nov 30, 2009
@mwhansen
Copy link
Contributor

mwhansen commented Dec 2, 2009

comment:4

This causes some failures in tests in sage/server/

@mwhansen
Copy link
Contributor

mwhansen commented Dec 2, 2009

Author: Tim Dumol

@mwhansen
Copy link
Contributor

mwhansen commented Dec 2, 2009

Reviewer: Mike Hansen

@mwhansen
Copy link
Contributor

mwhansen commented Dec 2, 2009

comment:5

{{{ sage -t devel/sage-main/sage/server/notebook/notebook_object.py # 4 doctests failed
}}}

@williamstein
Copy link
Contributor

comment:6

Replying to @mwhansen:

{{{ sage -t devel/sage-main/sage/server/notebook/notebook_object.py # 4 doctests failed
}}}

Since the code isn't being run and is officially "deprecated", one option is to put a nodoctest.py file in the directory (or #nodoctest at the top of the file) so that the code isn't tested.

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Dec 10, 2009

Adds nodoctest.py files. Replacement patch.

@qed777
Copy link
Mannequin Author

qed777 mannequin commented Dec 10, 2009

comment:7

Attachment: trac_7534-deprecation-message_v2.patch.gz

V2 suppresses doctesting for the "deprecated" files.

@qed777 qed777 mannequin added s: needs review and removed s: needs work labels Dec 10, 2009
@williamstein
Copy link
Contributor

comment:8

Looks good to me now.

@mwhansen
Copy link
Contributor

Merged: sage-4.3.rc1

@sagetrac-mvngu sagetrac-mvngu mannequin added this to the sage-4.3 milestone Dec 26, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants