Update the Twisted package to 9.0

[TimDumol]

Twisted has just recently released a new version, 9.0. This update includes several major changes, the most significant to Sage development being support for WSGI in the Twisted.web framework (rather than the Twisted.web2 framework).

Release notes:
http://twistedmatrix.com/trac/browser/tags/releases/twisted-9.0.0/NEWS?format=raw

---

New package up at http://sage.math.washington.edu/home/mpatel/trac/7552/twisted-9.0.p2.spkg

CC: @mwhansen @jaapspies

Component: packages: standard

Author: Tim Dumol, Jaap Spies

Reviewer: William Stein, Mitesh Patel, David Kirkby

Merged: sage-4.3.4.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7552

[TimDumol]

comment:1

Markup change.

[TimDumol]

comment:2

New package up at http://sage.math.washington.edu/home/timdumol/twisted-9.0.p0.spkg. I've tried it on a few worksheets, and things seem to be working well. The notebook tests pass as well.

[TimDumol]

comment:3

Added package link to description.

[TimDumol]

comment:4

Added release notes.

[williamstein]

comment:5

1. Typing "hg status" gives:

wstein@sage:~/build/referee/sage-4.3.rc0/twisted-9.0.p0$ hg status
! patches/keys.py
! patches/sob.py

This is because you just deleted those files instead of doing "hg rm". To fix, put them back, then do "hg rm".

2. You forgot to remove patches/filepath.py, but aren't using it anymore:

-cp patches/filepath.py src/twisted/python/

[TimDumol]

comment:6

New version with the fixes at http://sage.math.washington.edu/home/timdumol/twisted-9.0.p0.spkg. I neglected changing the version number.

[qed777]

comment:7

Should we add

rm -rf "$SAGE_LOCAL"/lib/python/site-packages/twisted

to

# Deleting the old version is *very* important with this package.
rm -rf "$SAGE_LOCAL"/lib/python/site-packages/Twisted*

in spkg-install?

[qed777]

comment:8

Also, hg ci.

[qed777]

comment:9

Replying to @qed777:

Also, hg ci.

Oops. I mean that hg stat gives

! patches/filepath.py
! patches/filepath.py.patch
! patches/keys.py
! patches/keys.py.patch
! patches/sob.py
! patches/sob.py.patch

[qed777]

Author: Tim Dumol

[qed777]

comment:10

I've put these changes and added a description to SPKG.txt in

• http://sage.math.washington.edu/home/mpatel/trac/7552/twisted-9.0.p1.spkg

I didn't upgrade zope.interface to 3.5.3, since sagenb-*.spkg includes it.

The Se and doc tests pass for me. Positive review, but someone should review my changes.

[qed777]

Reviewer: William Stein, Mitesh Patel

[sagetrac-drkirkby]

comment:11

I've not checked it for functionality, but this does at least build on Solaris.

Dave

[qed777]

comment:12

Requesting an assist, whenever it's convenient.

[sagetrac-drkirkby]

comment:13

Also see #8352, which makes a very small change to twisted's spkg-install file, so the previous version of twisted builds on any platform as 64-bit, not just OS X.

Basically changing

if [ `uname` = "Darwin" -a "$SAGE64" = "yes" ]; then
   echo "64 bit MacIntel"
   CFLAGS="-O2 -g -m64 "; export CFLAGS
   LDFLAGS="-m64 "; export LDFLAGS
fi

to

if ["x$SAGE64" = xyes ]; then
   echo "64 bit build"
   CFLAGS="-O2 -g -m64 "; export CFLAGS
   LDFLAGS="-m64 "; export LDFLAGS
fi

I'm happy to give the other ticket positive review, but are not going to just now, until I find the best way of handling this.

Dave

[sagetrac-drkirkby]

comment:14

I got no feedback from sage-devel on the best way to handle this, so I've give #8352 positive review.

I'm not marking it as 'needs work', as that might not be the right thing to do, it might be best if you incorporate the changes from that ticket too.

[qed777]

comment:15

I've added #8352's patch to

• http://sage.math.washington.edu/home/mpatel/trac/7552/twisted-9.0.p2.spkg

Let me know if there are any problems.

[sagetrac-drkirkby]

Changed reviewer from William Stein, Mitesh Patel to William Stein, Mitesh Patel, David Kirkby

[sagetrac-drkirkby]

comment:16

I think the first release of this in SPKG.txt should have been simply twisted-9.0 and not twisted-9.0.p0. The p's are only added after patches are applied at a later date. But it is pretty clear from the message that this was the first time version 9.0 was used, so I'm going to overlook that.

I've added Jaap Spies as an author, as his changes are incorporated too.

Note to the release manager. When this ticket is merged, #8352 can be closed.

[sagetrac-drkirkby]

Changed author from Tim Dumol to Tim Dumol, Jaap Spies

[sagetrac-mvngu]

comment:17

Merged twisted-9.0.p2.spkg in the standard spkg repository.

[sagetrac-mvngu]

Merged: sage-4.3.4.alpha0