Memleak in GLPK interface

[malb]

The GLPK interface sage_mallocs various arrays and never frees them. Also the interface uses Python keywords as variable names.

CC: @nathanncohen

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/7572

[malb]

comment:1

Attachment: glpk_sage_free.patch.gz

The attached patch is for the GLPK SPKG.

[nathanncohen]

comment:2

Thank you for your help !!! just one question though : on which version of GLPK is your patch based ? The new version of GLPK is available in #7268 and still waiting for review... Could we merge your changes in ? :-)

I had no idea that "id" was a python keyword... And thank you for noticing this memory leak !

Nathann

[malb]

comment:3

Replying to @nathanncohen:

Thank you for your help !!! just one question though : on which version of GLPK is your patch based ? The new version of GLPK is available in #7268 and still waiting for review... Could we merge your changes in ? :-)

Sure, I'll take a look at #7268.

I had no idea that "id" was a python keyword... And thank you for noticing this memory leak !

Me neither, but Emacs noticed it :) I think there's still a memleak there, you new glp_ioct but never delete it. However, I couldn't find anything on glp_ioct anywhere.

[nathanncohen]

comment:4

This could be deleted as part of the whole GLPK version of the LP syste, though... But it could be good to take a look at it, indeed :-)

Nathann

[malb]

comment:5

This is now fixed in #7268