New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvements to the prove_BSD function #7576
Comments
This comment has been minimized.
This comment has been minimized.
comment:3
REFEREE REPORT:
E.g., the proof one should be:
I find it useful to try making a simple function with the given docstring in the notebook, then evaluate and introspect that, to see what Sphinx does.
This might be related to how you setup the alarm. It's hard to tell.
Also, the above hard-coded 100 makes me a little nervous. What happens if we go through the whole list of 100 and don't find one that works? (Highly unlikely in practice, of course.) Then we think the last one we looked at does work. Not good.
It's trivial that
|
comment:4
I think I've addressed all your comments, including handling the alarm better. |
comment:5
New report:
Otherwise, everse looks good. |
comment:8
For 438e1 and 960d1, we get:
|
comment:9
Copying from Facebook again:
|
comment:10
For the record, it is hardly correct to say that a rank bound of 1 is wrong when the rank is zero! But I know from communication from Weigandt that what the verbose output of mwrank claims to be the "2-Selmer rank" is not always that. I should send rlm the example he sent me. |
comment:11
Needs work:
|
comment:12
I wasn't able to include a doctest for |
Attachment: trac_7576-flat.patch.gz |
comment:13
I tried the following conductor "swaths" and the only error I ran into was caused by the issue at #7575 (I also interrupted a few since they were taking forever):
|
comment:14
Just tried |
Reviewer: William Stein |
Merged: sage-4.3.1.rc1 |
This patch makes several improvements to the prove_BSD function:
better handling of when the Heegner index is computed
speeds up several cases and makes some other cases possible
uses results from Dimitar Jetchev's thesis when applying the Kolyvagin bound
Component: elliptic curves
Author: Robert Miller
Reviewer: William Stein
Merged: sage-4.3.1.rc1
Issue created by migration from https://trac.sagemath.org/ticket/7576
The text was updated successfully, but these errors were encountered: